Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): add support for pushing proto definitions to Buf Schema Registry #1510

Open
wants to merge 13 commits into
base: v0.34.x-celestia
Choose a base branch
from

Conversation

rach-id
Copy link
Member

@rach-id rach-id commented Oct 7, 2024

Adds support to pushing proto definitions to BSR when releasing.

This will be helpful to import RowProof, ShareProof, etc from downstream repos without redefining them.

I guess we can keep pushing our protos to BSR even if we decide to move these definitions to go-square

@rach-id rach-id self-assigned this Oct 7, 2024
@rach-id rach-id requested a review from a team as a code owner October 7, 2024 20:35
@rach-id rach-id requested review from staheri14 and ninabarbakadze and removed request for a team October 7, 2024 20:35
@rach-id
Copy link
Member Author

rach-id commented Oct 7, 2024

Buf ci should hopefuly be fixed with: #1511

@rach-id rach-id requested a review from rootulp October 7, 2024 20:43
rach-id and others added 8 commits October 8, 2024 16:35
deletes buf.work.yaml for the buf CI in
#1510 to work
…1512)

Bumps [github.com/celestiaorg/nmt](https://github.com/celestiaorg/nmt)
from 0.22.1 to 0.22.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/celestiaorg/nmt/releases">github.com/celestiaorg/nmt's
releases</a>.</em></p>
<blockquote>
<h2>v0.22.2</h2>
<h2>What's Changed</h2>
<ul>
<li>chore(deps): bump github.com/tidwall/gjson from 1.17.1 to 1.17.3 by
<a href="https://github.com/dependabot"><code>@​dependabot</code></a> in
<a
href="https://redirect.github.com/celestiaorg/nmt/pull/271">celestiaorg/nmt#271</a></li>
<li>docs: add comment to leaf case in verify subtree roots inclusion by
<a href="https://github.com/rach-id"><code>@​rach-id</code></a> in <a
href="https://redirect.github.com/celestiaorg/nmt/pull/272">celestiaorg/nmt#272</a></li>
<li>ci: support releasing proto definitions to BSR by <a
href="https://github.com/rach-id"><code>@​rach-id</code></a> in <a
href="https://redirect.github.com/celestiaorg/nmt/pull/274">celestiaorg/nmt#274</a></li>
<li>fix(ci): update the Buf CI to push tags to the Buf Schema Registry
by <a href="https://github.com/rach-id"><code>@​rach-id</code></a> in <a
href="https://redirect.github.com/celestiaorg/nmt/pull/280">celestiaorg/nmt#280</a></li>
<li>chore(deps): bump github.com/tidwall/gjson from 1.17.3 to 1.18.0 by
<a href="https://github.com/dependabot"><code>@​dependabot</code></a> in
<a
href="https://redirect.github.com/celestiaorg/nmt/pull/277">celestiaorg/nmt#277</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/celestiaorg/nmt/compare/v0.22.1...v0.22.2">https://github.com/celestiaorg/nmt/compare/v0.22.1...v0.22.2</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/celestiaorg/nmt/commit/c1a9cfc042eb30384ba8f6187258cf285eff86be"><code>c1a9cfc</code></a>
chore(deps): bump github.com/tidwall/gjson from 1.17.3 to 1.18.0 (<a
href="https://redirect.github.com/celestiaorg/nmt/issues/277">#277</a>)</li>
<li><a
href="https://github.com/celestiaorg/nmt/commit/b2a01871d63e87c9766b11f93e482c954c2d6494"><code>b2a0187</code></a>
fix(ci): update the Buf CI to push tags to the Buf Schema Registry (<a
href="https://redirect.github.com/celestiaorg/nmt/issues/280">#280</a>)</li>
<li><a
href="https://github.com/celestiaorg/nmt/commit/d6a34366eee7898ba2ca44814d9b14cf4d07bbfd"><code>d6a3436</code></a>
ci: support releasing proto definitions to BSR (<a
href="https://redirect.github.com/celestiaorg/nmt/issues/274">#274</a>)</li>
<li><a
href="https://github.com/celestiaorg/nmt/commit/29e9433bd79eed40462000626ef987c91b0cf523"><code>29e9433</code></a>
docs: add comment to leaf case in verify subtree roots inclusion (<a
href="https://redirect.github.com/celestiaorg/nmt/issues/272">#272</a>)</li>
<li><a
href="https://github.com/celestiaorg/nmt/commit/cce31e890f382c1b90241a7340327f76c252a0cf"><code>cce31e8</code></a>
chore(deps): bump github.com/tidwall/gjson from 1.17.1 to 1.17.3 (<a
href="https://redirect.github.com/celestiaorg/nmt/issues/271">#271</a>)</li>
<li>See full diff in <a
href="https://github.com/celestiaorg/nmt/compare/v0.22.1...v0.22.2">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github.com/celestiaorg/nmt&package-manager=go_modules&previous-version=0.22.1&new-version=0.22.2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@rach-id rach-id enabled auto-merge (squash) October 8, 2024 17:21
@rach-id rach-id disabled auto-merge October 8, 2024 17:21
@rach-id rach-id enabled auto-merge (squash) October 8, 2024 17:21
evan-forbes
evan-forbes previously approved these changes Nov 15, 2024
@rach-id rach-id dismissed evan-forbes’s stale review November 15, 2024 17:27

The merge-base changed after approval.

rach-id added a commit that referenced this pull request Nov 18, 2024
deletes buf.work.yaml for the buf CI in
#1510 to work
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants