Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Update Grant Amount in Celestia's FeeGrant Module #3916

Open
a26nine opened this issue Nov 5, 2024 · 1 comment
Open
Labels
area:api Related to celestia-node API enhancement New feature or request external Issues created by non node team members

Comments

@a26nine
Copy link

a26nine commented Nov 5, 2024

Implementation ideas

Feature Request: Update Grant Amount in Celestia's FeeGrant Module

Description:

The feeGrant module in celestia-node enables a Granter to cover the transaction fees of a Grantee's blob submission. This is facilitated by granting a fee allowance, which authorizes the Grantee to submit blobs on behalf of the Granter up to a specified threshold.

Problem:

Currently, there's no way to modify the "grant amount" once it's set. Attempting to update it using the same process results in the following error:

failed to execute message; message index: 0: fee allowance already exists: invalid request

This behavior is evident in this transaction, which fails when attempting to increase the allowance for an existing grant.

Proposed Solution:

Implement a feature that allows updating an existing grant amount. This would improve flexibility by eliminating the need to revoke the previous grant and create a new one each time a threshold adjustment is necessary.

Benefits:

  • Simplifies workflows for managing allowances
  • Reduces redundant transactions related to revoking and re-granting allowances
  • Enhances usability for users leveraging the feeGrant module
@a26nine a26nine added the enhancement New feature or request label Nov 5, 2024
@github-actions github-actions bot added the external Issues created by non node team members label Nov 5, 2024
@jcstein
Copy link
Member

jcstein commented Nov 5, 2024

I agree that this would be useful. I think this also may need a corresponding issue to be made in https://github.com/celestia-app

@vgonkivs vgonkivs added the area:api Related to celestia-node API label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:api Related to celestia-node API enhancement New feature or request external Issues created by non node team members
Projects
None yet
Development

No branches or pull requests

3 participants