Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: Investigate whether to use tmjson encoding on types shared between node + celestia-core #3935

Open
renaynay opened this issue Nov 13, 2024 · 0 comments
Assignees
Labels
area:api Related to celestia-node API

Comments

@renaynay
Copy link
Member

renaynay commented Nov 13, 2024

We currently have a feature branch feature/api-breaks that will contain several breaking changes to the way some types are encoded in json, introduced by the Eiger team. The purpose of those changes was to ensure parity between the way types shared by node and celestia-core are encoded/decoded.

We currently have some fields (namely inside ExtendedHeader) that are tmjson encoded, so the proposal is just to tmjson the whole struct.

Originally, Preston from sovereign asked for parity encoding for those fields in #1476, referencing https://github.com/tendermint/tendermint/pull/7670/files which actually never ended up in celestia-core.

AFAIU, it seems the one thing that needs to be done to ensure parity between the encoding of types is to string marshal 64-bit integers which begs the question of whether we actually need to use tmjson at all, but rather just enforce string conversion for int64.


@renaynay renaynay added area:api Related to celestia-node API and removed needs:triage labels Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:api Related to celestia-node API
Projects
None yet
Development

No branches or pull requests

2 participants