Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nodebuilder/node | api): Version the API #1901

Merged
merged 4 commits into from
Mar 23, 2023

Conversation

renaynay
Copy link
Member

@renaynay renaynay commented Mar 13, 2023

Introduce a version string to the API

Resolves #1345

@renaynay renaynay added kind:misc Attached to miscellaneous PRs area:api Related to celestia-node API labels Mar 13, 2023
@renaynay renaynay self-assigned this Mar 13, 2023
@renaynay
Copy link
Member Author

Kinda hesitant to merge this til we have header.Subscription endpoint - but who knows how long gomock will take to impl support for generics.

Copy link
Collaborator

@distractedm1nd distractedm1nd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check api/docgen/openrpc.go line 23 - there is a const there that declares the api version, so we should combine these

@renaynay renaynay marked this pull request as ready for review March 17, 2023 09:40
@renaynay
Copy link
Member Author

Marking ready for review as API is not yet stable so let's just make it first minor version.

distractedm1nd
distractedm1nd previously approved these changes Mar 17, 2023
walldiss
walldiss previously approved these changes Mar 17, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #1901 (7267277) into main (045c4fe) will decrease coverage by 3.21%.
The diff coverage is 59.52%.

@@            Coverage Diff             @@
##             main    #1901      +/-   ##
==========================================
- Coverage   57.79%   54.58%   -3.21%     
==========================================
  Files         245      214      -31     
  Lines       16184    13631    -2553     
==========================================
- Hits         9354     7441    -1913     
+ Misses       5882     5403     -479     
+ Partials      948      787     -161     
Impacted Files Coverage Δ
api/docgen/openrpc.go 0.00% <ø> (ø)
das/coordinator.go 89.18% <ø> (ø)
das/daser.go 67.03% <ø> (ø)
das/subscriber.go 88.23% <ø> (ø)
das/worker.go 96.33% <ø> (ø)
header/headertest/testing.go 83.39% <0.00%> (ø)
header/verify.go 88.00% <ø> (ø)
libs/fraud/proof.go 70.96% <ø> (ø)
libs/fraud/testing.go 90.27% <ø> (ø)
nodebuilder/core/module.go 80.95% <ø> (ø)
... and 23 more

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@walldiss walldiss dismissed stale reviews from distractedm1nd and themself via 7267277 March 23, 2023 08:33
@renaynay renaynay merged commit 258b465 into celestiaorg:main Mar 23, 2023
@renaynay renaynay deleted the version-api branch March 23, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:api Related to celestia-node API kind:misc Attached to miscellaneous PRs
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

rpc: decide on versioning
6 participants