-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nodebuilder/node | api): Version the API #1901
Conversation
Kinda hesitant to merge this til we have |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check api/docgen/openrpc.go
line 23 - there is a const there that declares the api version, so we should combine these
Marking ready for review as API is not yet stable so let's just make it first minor version. |
0273502
to
7267277
Compare
Codecov Report
@@ Coverage Diff @@
## main #1901 +/- ##
==========================================
- Coverage 57.79% 54.58% -3.21%
==========================================
Files 245 214 -31
Lines 16184 13631 -2553
==========================================
- Hits 9354 7441 -1913
+ Misses 5882 5403 -479
+ Partials 948 787 -161
... and 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Introduce a version string to the API
Resolves #1345