refactor(api/gateway) return error from gateway if header is not synced yet #2108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walldiss
added
area:api
walldiss
requested review from
Wondertan,
vgonkivs and
distractedm1nd
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2108 +/- ##
==========================================
- Coverage 55.67% 55.49% -0.19%
==========================================
Files 209 209
Lines 13267 13321 +54
==========================================
+ Hits 7387 7393 +6
- Misses 5135 5186 +51
+ Partials 745 742 -3
... and 10 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Perfect, let's add a TODO that we will change this to NetworkHead from LocalHead once the adjacency in the store is fixed. Issue to link: celestiaorg/go-header#32 |
renaynay
reviewed
Apr 20, 2023
renaynay
approved these changes
Apr 20, 2023
Wondertan
approved these changes
Apr 20, 2023
|
Fixes #2118 |
Wondertan
pushed a commit
that referenced
this pull request
Apr 27, 2023
…ed yet (#2108) ## Overview If header was not in header store, gateway would hang until client context was canceled. PR allows gateway to return an error immediately in this case. --------- Co-authored-by: rene <41963722+renaynay@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
If header was not in header store, gateway would hang until client context was canceled. PR allows gateway to return an error immediately in this case.