fix: check if param store is defined #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-forbes
approved these changes
May 30, 2024
rootulp
commented
May 31, 2024
Comment on lines
+10
to
+18
| // TestSetAppVersion verifies that SetAppVersion does not panic if paramStore is nil. | ||
| func TestSetAppVersion(t *testing.T) { | ||
| baseApp := NewBaseApp("test", nil, nil, nil) | ||
| baseApp.paramStore = nil // explicitly set to nil | ||
|
|
||
| require.NotPanics(t, func() { | ||
| baseApp.SetAppVersion(types.Context{}, uint64(1)) | ||
| }) | ||
| } |
There was a problem hiding this comment.
note this test failed before the change in this PR so this test should catch regressions if we attempt to merge in upstream changes from cosmos-sdk and accidentally revert the implementation change in options.go
ninabarbakadze
approved these changes
May 31, 2024
rootulp
merged commit 7f62ee5
into
celestiaorg:release/v0.46.x-celestia
33 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unblocks celestiaorg/celestia-app#3517
Relevant context: https://github.com/celestiaorg/celestia-app/pull/3177/files#r1621285673