-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement diataxis #1742
base: main
Are you sure you want to change the base?
Implement diataxis #1742
Conversation
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
@jcstein i have a few questions:
Thank you! |
yep! will review once done
let's try to keep the broken links to a minimum here if possible. wdyt? |
i'm going to take some time to review this and give you better answers on these points. as i realize this Issue inherently breaks a lot of links |
link: "https://docs.astria.org/developer/tutorials/install-the-cli", | ||
}, | ||
], | ||
text: "How To Guides", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
text: "How To Guides", | |
text: "How-to guides", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and any other instances of this, should change to this 🙏
{ | ||
text: "Awesome Celestia resources", | ||
link: "https://github.com/celestiaorg/awesome-celestia/", | ||
text: "Join the network", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consider reworking this to highilght the new categories and keeping some things like "blob tutorial" here too
collapsed: true, | ||
items: [ | ||
text: "Build whatever", | ||
link: "/how-to-guides/build-whatever", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
celestia.org/how-to-guides/build-whatever
is clear and also has a nice ring. thank you @Mackenzie-OO7 and Diataxis!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM aside a few small requests!
closes #1534