Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missed "no click heres" #1110

Merged
merged 2 commits into from
Oct 5, 2023
Merged

fix: missed "no click heres" #1110

merged 2 commits into from
Oct 5, 2023

Conversation

jcstein
Copy link
Member

@jcstein jcstein commented Oct 4, 2023

Overview

Issue #1073 was made to remove instances of "click here" in the documentation. #1093 resolved this issue, but I missed a few instances of this and noticed when I was updating the QGB source with the same rule.

Note: a follow-up PR will be made to bring in changes from QGB source. This is why there are still instances of [here] in qgb-*.md pages on this branch and main.

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@jcstein jcstein requested a review from YazzyYaz October 4, 2023 16:56
@jcstein jcstein self-assigned this Oct 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

PR Preview Action v1.4.4
🚀 Deployed preview to https://celestiaorg.github.io/docs/pr-preview/pr-1110/
on branch gh-pages at 2023-10-04 19:04 UTC

@jcstein jcstein requested review from rootulp and removed request for YazzyYaz October 4, 2023 18:03
Copy link
Contributor

@rootulp rootulp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I don't understand what issue this PR is fixing. Do you mind rephrasing the PR description or linking to a GH issue?

FWIW I would approve after one blocking change.

docs/nodes/full-storage-node.mdx Outdated Show resolved Hide resolved
Co-authored-by: Rootul P <rootulp@gmail.com>
@jcstein jcstein requested a review from rootulp October 4, 2023 19:09
@jcstein jcstein added the documentation Improvements or additions to documentation label Oct 4, 2023
@jcstein jcstein merged commit 5bd49d6 into main Oct 5, 2023
5 checks passed
@jcstein jcstein deleted the jcs/missed-click-heres branch October 5, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants