-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Increase LN disk recommendation to 100GB and bridge/full RAM to 16GB #1564
Conversation
It's supposed to be temporary, so give us some buffer until the sample and header pruning is finished. Afterward, we can revert and even decrease to ~5GB with pruning milestones finished
Important Auto Review SkippedReview was skipped due to path filters Files ignored due to path filters (1)
You can disable this status message by setting the WalkthroughThe recent updates involve increasing the minimum SSD storage requirement for light nodes to 100 GB and updating the minimum recommended memory requirement for bridge and full-storage nodes to 16 GB RAM. These changes aim to enhance the performance and stability of the nodes under varying resource constraints. Changes
Possibly related issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Out of diff range and nitpick comments (2)
nodes/light-node.md (2)
Line range hint
84-84
: Consider adding a comma after "machine" for better readability.- ...required to be open on your machine. To start the light node with a connection to a v... + ...required to be open on your machine, to start the light node with a connection to a v...
Line range hint
182-182
: Consider rephrasing to avoid wordiness.- In order to run a light node using a custom key: + To run a light node with a custom key:
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- nodes/light-node.md (1 hunks)
Additional Context Used
LanguageTool (2)
nodes/light-node.md (2)
Near line 84: Possible missing comma found.
Context: ...equired to be open on your machine. To start the light node with a connection to a v...
Near line 182: Consider a shorter alternative to avoid wordiness.
Context: ...: run the light node with a custom key In order to run a light node using a custom key: 1...
Additional comments not posted (1)
nodes/light-node.md (1)
32-32
: Updated disk storage requirement to 100 GB SSD Storage.
TODO
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Out of diff range and nitpick comments (6)
nodes/full-storage-node.md (5)
Line range hint
36-36
: Fix the unpaired markdown link symbol.- You can follow [the tutorial for setting up your dependencies + You can follow [the tutorial for setting up your dependencies]
Line range hint
40-40
: Fix the unpaired markdown link symbol.- You can follow [the tutorial for installing `celestia-node` + You can follow [the tutorial for installing `celestia-node`]
Line range hint
92-92
: Fix the unpaired markdown link symbol.- [the `cel-key` instructions](../../developers/celestia-node-key + [the `cel-key` instructions](../../developers/celestia-node-key)
Line range hint
123-123
: Consider rephrasing to avoid wordiness.- In order to run a full storage node using a custom key: + To run a full storage node using a custom key:
Line range hint
159-159
: Consider rephrasing to avoid wordiness.- In order to gracefully stop the full storage node, use `Control + C` in the + To gracefully stop the full storage node, use `Control + C` in thenodes/bridge-node.md (1)
Line range hint
167-167
: Consider rephrasing to avoid wordiness.- In order to run a bridge node using a custom key: + To run a bridge node using a custom key:
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- nodes/bridge-node.md (1 hunks)
- nodes/full-storage-node.md (1 hunks)
Additional Context Used
LanguageTool (6)
nodes/bridge-node.md (1)
Near line 167: Consider a shorter alternative to avoid wordiness.
Context: ... run the bridge node with a custom key In order to run a bridge node using a custom key: ...nodes/full-storage-node.md (5)
Near line 36: Unpaired symbol: ‘]’ seems to be missing
Context: ... Setup the dependencies You can follow [the tutorial for setting up your depende...
Near line 40: Unpaired symbol: ‘]’ seems to be missing
Context: ...# Install celestia-node You can follow [the tutorial for installing `celestia-no...
Near line 92: Unpaired symbol: ‘]’ seems to be missing
Context: ...ate your key for your node by following [thecel-key
instructions](../../develo...
Near line 123: Consider a shorter alternative to avoid wordiness.
Context: ...he full storage node with a custom key In order to run a full storage node using a custom ...
Near line 159: Consider a shorter alternative to avoid wordiness.
Context: ... node. ### Stop the full storage node In order to gracefully stop the full storage node, ...
Additional comments not posted (2)
nodes/full-storage-node.md (1)
25-25
: Memory requirement updated to 16 GB RAM.nodes/bridge-node.md (1)
50-50
: Memory requirement updated to 16 GB RAM.
It's supposed to be temporary to give us some buffer until the sample and header pruning is finished. Afterward, we can revert and even decrease to ~5GB with pruning milestones finished.
Summary by CodeRabbit