Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix typos in documentation for multiple files #1780

Merged
merged 5 commits into from
Nov 5, 2024

Conversation

cypherpepe
Copy link
Contributor

@cypherpepe cypherpepe commented Nov 4, 2024

Overview

Description:
Added typo corrections to documentation for the following files:

  • arabica-devnet.md
  • arbitrum-integration.md
  • blobstream-offchain.md
  • blobstream-x-deploy.md
  • celestia-app-vesting.md

Goal:
Correct grammatical errors and improve readability of the documentation.

Summary by CodeRabbit

Release Notes

  • Documentation Updates
    • Enhanced clarity and corrected minor issues in the Arabica devnet guide.
    • Expanded overview of Arbitrum Nitro integration, detailing key components and functionalities.
    • Provided a comprehensive guide for integrating Layer 2 offchain logic with Blobstream.
    • Updated instructions for deploying BlobstreamX, including prerequisites and deployment steps.
    • Corrected a typographical error in the Celestia application home directory variable name.

Copy link
Contributor

coderabbitai bot commented Nov 4, 2024

Walkthrough

This pull request includes updates to several documentation files, focusing on enhancing clarity and correcting minor issues. Key changes involve removing duplicated words, refining explanations, and correcting typographical errors across various guides related to the Arabica devnet, Arbitrum integration, Blobstream, and deployment instructions. The modifications aim to improve the readability and accuracy of the documents while preserving their original structure and content.

Changes

File Path Change Summary
how-to-guides/arabica-devnet.md Removed duplicated word in network upgrades section; overall clarity improvements.
how-to-guides/arbitrum-integration.md Expanded overview of Arbitrum Nitro and Celestia integration; clarified key components and mechanisms.
how-to-guides/blobstream-offchain.md Introduced new data structures and clarified the role of the sequencer; corrected header structure.
how-to-guides/blobstream-x-deploy.md Provided detailed deployment instructions for BlobstreamX; included steps for setting up contracts.
how-to-guides/celestia-app-vesting.md Corrected variable name from CElESTIA_APP_HOME to CELESTIA_APP_HOME for consistency.

Possibly related PRs

Suggested labels

documentation

Suggested reviewers

  • jcstein
  • Ferret-san

Poem

🐇 In the land of code where rabbits hop,
Documentation grows, we never stop.
With clarity bright and errors gone,
Our guides now shine like the morning dawn!
So leap with joy, dear developer friends,
For clearer paths lead to joyful ends! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (5)
how-to-guides/arbitrum-integration.md (2)

60-60: Improve readability by reducing wordiness.

Consider simplifying "in order to" to just "to" for better conciseness.

-In order to support fraud proofs, this integration has the necessary code for a Nitro validator to populate its preimage mapping with Celestia hashes that then get "unpeeled" in order to reveal the full data for a Blob.
+In order to support fraud proofs, this integration has the necessary code for a Nitro validator to populate its preimage mapping with Celestia hashes that then get "unpeeled" to reveal the full data for a Blob.
🧰 Tools
🪛 LanguageTool

[style] ~60-~60: Consider a shorter alternative to avoid wordiness.
Context: ...elestia hashes that then get "unpeeled" in order to reveal the full data for a Blob. You ca...

(IN_ORDER_TO_PREMIUM)


67-67: Add commas around the interruptive phrase.

The phrase "in fact" should be set off by commas as it's an interruptive phrase.

-Because only data roots that can be confirmed on Blobstream get accepted into the sequencer inbox, one can have a high degree of certainty that the canonical data root being unpeeled as well as the row roots are in fact correct.
+Because only data roots that can be confirmed on Blobstream get accepted into the sequencer inbox, one can have a high degree of certainty that the canonical data root being unpeeled as well as the row roots are, in fact, correct.
🧰 Tools
🪛 LanguageTool

[typographical] ~67-~67: Consider isolating this adverbial phrase with commas.
Context: ...ng unpeeled as well as the row roots are in fact correct. ### Blobstream X implementati...

(IN_FACT_COMMA_2)

how-to-guides/celestia-app-vesting.md (2)

Line range hint 48-54: Fix inconsistency in variable name casing

The explanation text correctly uses CELESTIA_APP_HOME, but the code block below still shows CElESTIA_APP_HOME. This inconsistency should be fixed to avoid confusion.

Apply this diff to fix the variable name in the code block:

-export CElESTIA_APP_HOME=/var/folders/_8/ljj6hspn0kn09qf9fy8kdyh40000gn/T/celestia_app_XXXXXXXXXXXXX.XV92a3qx
+export CELESTIA_APP_HOME=/var/folders/_8/ljj6hspn0kn09qf9fy8kdyh40000gn/T/celestia_app_XXXXXXXXXXXXX.XV92a3qx

Line range hint 82-83: Fix variable name casing in all command examples

The incorrect variable name $CElESTIA_APP_HOME is used consistently throughout all command examples. This should be updated to $CELESTIA_APP_HOME to match the explanation text.

All command examples need to be updated. Here's an example of how the commands should look:

-./celestia-appd keys add vesting-key --home $CElESTIA_APP_HOME
+./celestia-appd keys add vesting-key --home $CELESTIA_APP_HOME

-./celestia-appd keys list --home $CElESTIA_APP_HOME
+./celestia-appd keys list --home $CELESTIA_APP_HOME

-./celestia-appd tx vesting create-vesting-account $TO_ADDRESS 100000utia 1686748051 --from $FROM_ADDRESS --gas auto --fees 100000utia --chain-id private --home $CElESTIA_APP_HOME
+./celestia-appd tx vesting create-vesting-account $TO_ADDRESS 100000utia 1686748051 --from $FROM_ADDRESS --gas auto --fees 100000utia --chain-id private --home $CELESTIA_APP_HOME

Please update all remaining instances accordingly.

Also applies to: 89-90, 102-103, 108-109, 115-116, 122-123, 129-130, 136-137, 143-144

how-to-guides/blobstream-x-deploy.md (1)

165-165: Fix grammatical error: "setup" should be "set up"

The word "setup" is being used as a verb, but it's actually a noun. When used as a verb, it should be written as two words: "set up".

Apply this change:

-by default, the whitelist status is set to `Default`. This means that only the default verifier, which was setup when [deploying the SuccinctGateway](#d...
+by default, the whitelist status is set to `Default`. This means that only the default verifier, which was set up when [deploying the SuccinctGateway](#d...
🧰 Tools
🪛 LanguageTool

[grammar] ~165-~165: Make sure that the noun ‘setup’ is correct. Did you mean the past participle “set up”?
Context: ...at only the default verifier, which was setup when [deploying the SuccinctGateway](#d...

(BE_VB_OR_NN)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 8917681 and cd92f24.

📒 Files selected for processing (5)
  • how-to-guides/arabica-devnet.md (1 hunks)
  • how-to-guides/arbitrum-integration.md (1 hunks)
  • how-to-guides/blobstream-offchain.md (1 hunks)
  • how-to-guides/blobstream-x-deploy.md (2 hunks)
  • how-to-guides/celestia-app-vesting.md (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • how-to-guides/arabica-devnet.md
🧰 Additional context used
🪛 LanguageTool
how-to-guides/arbitrum-integration.md

[style] ~60-~60: Consider a shorter alternative to avoid wordiness.
Context: ...elestia hashes that then get "unpeeled" in order to reveal the full data for a Blob. You ca...

(IN_ORDER_TO_PREMIUM)


[typographical] ~67-~67: Consider isolating this adverbial phrase with commas.
Context: ...ng unpeeled as well as the row roots are in fact correct. ### Blobstream X implementati...

(IN_FACT_COMMA_2)

how-to-guides/blobstream-x-deploy.md

[grammar] ~165-~165: Make sure that the noun ‘setup’ is correct. Did you mean the past participle “set up”?
Context: ...at only the default verifier, which was setup when [deploying the SuccinctGateway](#d...

(BE_VB_OR_NN)

🔇 Additional comments (3)
how-to-guides/celestia-app-vesting.md (1)

Line range hint 1-500: Overall document structure and formatting looks good

Apart from the variable name casing issues, the document is well-structured with clear sections, properly formatted code blocks, and helpful examples.

how-to-guides/blobstream-offchain.md (1)

211-212: LGTM! Indentation fix improves readability.

The indentation correction for the Namespace and Span fields in the header initialization improves code block consistency and readability.

how-to-guides/blobstream-x-deploy.md (1)

57-57: LGTM!

The environment variable description is clear and accurate.

@jcstein jcstein merged commit 98170aa into celestiaorg:main Nov 5, 2024
2 checks passed
Copy link

gitpoap-bot bot commented Nov 5, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2024 Celestia Contributor:

GitPOAP: 2024 Celestia Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants