Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

store: Remove adjacency requirement from Store.Append #32

Closed
Wondertan opened this issue Apr 20, 2023 · 1 comment · Fixed by #186
Closed

store: Remove adjacency requirement from Store.Append #32

Wondertan opened this issue Apr 20, 2023 · 1 comment · Fixed by #186
Assignees
@cristaloleg

Comments

@Wondertan
Copy link
Member

Wondertan commented Apr 20, 2023 •
edited by renaynay
Loading

Removal of adjacency requirement in Store
- 1st step: break adjacency requirement in store (where headers are able to be written to disk that aren't adjacent, yet the Head is still the head of the contiguous chain segment)
- 2nd step: track tail of contiguous segment in Store (we already have a Head, but now we need a Tail)
- Tail just means that everything between store.Head and store.Tail is adjacent
@Wondertan Wondertan mentioned this issue Apr 20, 2023
Merged
@Wondertan Wondertan mentioned this issue May 8, 2023
Merged
5 tasks
@gupadhyaya gupadhyaya mentioned this issue Jun 13, 2023
Closed
@cristaloleg cristaloleg self-assigned this May 27, 2024
@cristaloleg cristaloleg mentioned this issue May 27, 2024
Merged
@cristaloleg
Copy link
Contributor

Draft impl #186

cristaloleg added a commit that referenced this issue Jun 10, 2024
@cristaloleg
feat(sync, store)!: Remove adjacency requirement from Store.Append (#186
72d6506 
)

## Overview

Things that gonna change after we drop adjacency requirement from
`Store.Append`:
- Obviously dropping `ErrNonAdjacent` (breaking change).
- `Store.Append` comment is **already** outdated (looks like there were
2 return params)
- `store.Store.Append` will not verify for adjacency (obviously)
- `Syncer.setSubjectiveHead` will not verify for `ErrNonAdjacent`
- adjacency check is happening in `sync` instead of `store`.

Fixes #32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cristaloleg cristaloleg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(sync, store)!: Remove adjacency requirement from Store.Append celestiaorg/go-header
2 participants
@cristaloleg @Wondertan