fix(store): respect context in flushLoop #214
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristaloleg
requested review from
tzdybal,
renaynay,
Wondertan,
vgonkivs,
gupadhyaya,
walldiss and
ramin
as code owners
cristaloleg
commented
Jul 29, 2024
| @@ -511,3 +514,16 @@ func indexTo[H header.Header[H]](ctx context.Context, batch datastore.Batch, hea | |||
| } | |||
| return nil | |||
| } | |||
|
|
|||
| // sleep with cancellation, returns nil when timer has fired, error otherwise. | |||
| func sleep(ctx context.Context, duration time.Duration) error { | |||
There was a problem hiding this comment.
Sadly this func isn't presented in stdlib sync package :(
cristaloleg
commented
Jul 29, 2024
|
|
||
| assert.Eventually(t, func() bool { | ||
| // accessing store.ds directly because inside store we use wrappedStore, | ||
| // accessing ds or rootDS directly will result in constant error due to key prefix. |
There was a problem hiding this comment.
Cost me 30min of my life :\
Wondertan
reviewed
Jul 29, 2024
| const maxRetrySleep = 100 * time.Millisecond | ||
| sleepDur := min(10*time.Duration(i+1)*time.Millisecond, maxRetrySleep) | ||
|
|
||
| if err := sleep(ctx, sleepDur); err != nil { |
There was a problem hiding this comment.
Isn't that the case that this context is never canceled in practice?
There was a problem hiding this comment.
Step 1: make to respect context.
Step 2: change context to something real.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
After #211 we can improve
Store[H].flushLoopa bit more: respect context. Also, added a test to verify that retries works.Lowered max sleep from 1sec, 100msec should be enough.