Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

!chore: drop DefaultHeightThreshold #221

Merged
merged 1 commit into from
Oct 22, 2024
Merged

!chore: drop DefaultHeightThreshold #221

merged 1 commit into from
Oct 22, 2024

Conversation

cristaloleg
Copy link
Contributor

Leftover after #216

@cristaloleg cristaloleg self-assigned this Oct 22, 2024
@Wondertan
Copy link
Member

I mentioned this here #216 (review) btw

@cristaloleg cristaloleg enabled auto-merge (squash) October 22, 2024 16:22
@cristaloleg
Copy link
Contributor Author

You did, but not the const:(

@Wondertan
Copy link
Member

default value

DefaultHeightThreshold

@cristaloleg cristaloleg merged commit 58a2cc6 into main Oct 22, 2024
4 checks passed
@cristaloleg cristaloleg deleted the fix/drop-default-h-t branch October 22, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vgonkivs vgonkivs vgonkivs approved these changes

@Wondertan Wondertan Wondertan approved these changes

@tzdybal tzdybal Awaiting requested review from tzdybal tzdybal is a code owner

@renaynay renaynay Awaiting requested review from renaynay renaynay is a code owner

@gupadhyaya gupadhyaya Awaiting requested review from gupadhyaya gupadhyaya is a code owner

@walldiss walldiss Awaiting requested review from walldiss walldiss is a code owner

Assignees

@cristaloleg cristaloleg

Labels
kind:break! kind:chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cristaloleg @Wondertan @vgonkivs