Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: give container name to resolve discrepancies between different docker builds #5

Closed
wants to merge 3 commits into from

Conversation

jcstein
Copy link
Member

@jcstein jcstein commented Dec 21, 2023

Overview

Pairs with celestiaorg/nitro#3
PR #4 changed the name of the path in the auth token setting of test-node.bash, but it is not standard across different operating systems.

Problem

Example on macOS when container is named nitro-testnode-da-1 :

✔ Container nitro-testnode-da-1              Started                   0.6s
Waiting for http://localhost:26659/header/1 to come up..........................................................................Done!
Error response from daemon: No such container: nitro-testnode_da_1

Example on Ubuntu when container is named nitro-testnode_da_1 :

✔ Container nitro-testnode_da_1              Started                   0.6s
Waiting for http://localhost:26659/header/1 to come up..........................................................................Done!
Error response from daemon: No such container: nitro-testnode-da-1

Solution

Give the container a name: da-celestia, keeping things standard across different OS.

 ✔ Container da-celestia                      Started                   0.1s
Waiting for http://localhost:26659/header/1 to come up...........................................................Done!
== Generating l1 keys

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

jcstein added a commit to celestiaorg/docs that referenced this pull request Dec 21, 2023
jcstein added a commit to celestiaorg/docs that referenced this pull request Dec 22, 2023
…eo (#1339)

* style: make in code block

* feat: add note about ram

* feat: add youtube video

* feat: add mocha deployment guide

* chore: formatting

* chore: fix formatting

* feat: add cover image

* feat: add another cover

* fix: internal link on deploy page

* fix: remove unecessary changes

* feat: add new container name

from celestiaorg/nitro-testnode#5

* feat: add code diff example

* feat: add container name as "new line" correctly

* fix: use current example path
@jcstein
Copy link
Member Author

jcstein commented Jan 11, 2024

@Ferret-san for review 🫡

@jcstein jcstein closed this Jan 11, 2024
@jcstein jcstein deleted the jcs/fix-container-again branch January 11, 2024 21:07
Ferret-san pushed a commit that referenced this pull request Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant