fix(nitro): reorg fix and minor refactoring #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…via dangerous-reaorg-on-read-failure flag
Ferret-san
requested changes
Jul 27, 2024
Ferret-san
approved these changes
Jul 28, 2024
Ferret-san
pushed a commit
that referenced
this pull request
Aug 27, 2024
* Run CI on integration branch * CI: separate build and test-go-deps steps * CI: set timeout to 20min for challeng tests They often take more than 10 minutes (which is the default).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Mainly this disable by default to re-org in case of celestia read failures (e.g. node not available or rpc call erroring). Can force to re-org setting explicitely
--celestia-cfg.dangerous-reorg-on-read-failure=true.Minors: