Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update nitro-testnode, name DA container celestia-da #3

Conversation

jcstein
Copy link
Member

@jcstein jcstein commented Dec 21, 2023

Overview

This resolves an underlying issue with nitro-testnode, on the default setup in documentation, so that developers have a standard name for the Celestia DA container, as celestia-da.

WIP: to be merged after:

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@jcstein jcstein changed the base branch from master to celestia-development December 21, 2023 17:17
@jcstein jcstein changed the title feat: name DA container celestia-da feat: update nitro-testnode, name DA container celestia-da Dec 21, 2023
@jcstein jcstein marked this pull request as draft December 21, 2023 17:20
@jcstein jcstein changed the base branch from celestia-development to blobstream-develop January 11, 2024 20:23
@jcstein
Copy link
Member Author

jcstein commented Jan 11, 2024

closing and will have @Ferret-san update commit of nitro-testnode on blobstream-develop branch of Nitro, once this is merged celestiaorg/nitro-testnode#10

@jcstein jcstein closed this Jan 11, 2024
@jcstein jcstein deleted the jcs/update-container-name branch January 11, 2024 21:43
Ferret-san pushed a commit that referenced this pull request Aug 27, 2024
Update submodules with espresso forks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants