Skip to content
This repository has been archived by the owner on Apr 15, 2024. It is now read-only.

chore: not sign nonce 1 #531

Merged
merged 2 commits into from
Oct 12, 2023
Merged

chore: not sign nonce 1 #531

merged 2 commits into from
Oct 12, 2023

Conversation

rach-id
Copy link
Member

@rach-id rach-id commented Oct 12, 2023

Overview

After thinking about this, there is no need to sign nonce 1 at all because if it is used, it will be the point of initialization of the QGB contract, thus, no need to sign it.

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@rach-id rach-id added the chore label Oct 12, 2023
@rach-id rach-id self-assigned this Oct 12, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #531 (e1259d9) into main (2c83c82) will decrease coverage by 0.05%.
Report is 2 commits behind head on main.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #531      +/-   ##
==========================================
- Coverage   24.48%   24.44%   -0.05%     
==========================================
  Files          29       29              
  Lines        2936     2941       +5     
==========================================
  Hits          719      719              
- Misses       2131     2136       +5     
  Partials       86       86              
Files Coverage Δ
orchestrator/orchestrator.go 1.91% <0.00%> (-0.04%) ⬇️

@rach-id rach-id enabled auto-merge (squash) October 12, 2023 12:12
@rach-id rach-id merged commit 88bb6df into celestiaorg:main Oct 12, 2023
12 of 14 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants