Tidy analyseNode #1295
Merged
Tidy analyseNode #1295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsorby
added
the
Modified feature
Makes the code easier to read/maintain for me... who tends to work on the analyser. :)
agarny
reviewed
Nov 9, 2024
There was a problem hiding this comment.
I honestly can't see how this is tidying up the code. There are now more if statements and we even call swapLeftAndRightChildren() (7.23k times in our tests, i.e. ~94% of the time!). IOW, the code is now less efficient and, for me, more difficult to understand.
Otherwise, if you are to "tidy" that bit of code then you might also want to "tidy" the case of a piecewise statement (search for childCount >= 2).
Bottom line, if you guys are happy with this PR then feel free to force merge it.
nickerso
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1293.