Deprecate gateway fee #2120
Merged
Deprecate gateway fee #2120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage from tests in coverage: 48.1% of statements across all listed packagescoverage: 57.9% of statements in consensus/istanbul coverage: 37.5% of statements in consensus/istanbul/announce coverage: 54.3% of statements in consensus/istanbul/backend coverage: 0.0% of statements in consensus/istanbul/backend/backendtest coverage: 24.3% of statements in consensus/istanbul/backend/internal/replica coverage: 61.8% of statements in consensus/istanbul/core coverage: 45.0% of statements in consensus/istanbul/db coverage: 0.0% of statements in consensus/istanbul/proxy coverage: 64.4% of statements in consensus/istanbul/uptime coverage: 51.8% of statements in consensus/istanbul/validator coverage: 79.2% of statements in consensus/istanbul/validator/random |
|
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2120 +/- ##
==========================================
+ Coverage 54.30% 55.32% +1.02%
==========================================
Files 692 674 -18
Lines 115642 113553 -2089
==========================================
+ Hits 62795 62825 +30
+ Misses 49014 46915 -2099
+ Partials 3833 3813 -20
☔ View full report in Codecov by Sentry. |
palango
force-pushed
the
palango/full-node-incentives
branch
2 times, most recently
from
2bc2a1a
to
7d79724
Compare
palango
force-pushed
the
palango/full-node-incentives
branch
from
628bdaa
to
56a981c
Compare
palango
force-pushed
the
palango/full-node-incentives
branch
3 times, most recently
from
2fc9742
to
e0ccae3
Compare
gastonponti
reviewed
Jun 9, 2023
palango
force-pushed
the
palango/full-node-incentives
branch
from
e0ccae3
to
0b4d347
Compare
|
Changes after review:
|
palango
force-pushed
the
palango/full-node-incentives
branch
from
0b4d347
to
d49641a
Compare
palango
force-pushed
the
palango/full-node-incentives
branch
2 times, most recently
from
31a1cf7
to
12248be
Compare
karlb
reviewed
Jun 16, 2023
| @@ -1 +1 @@ | |||
| d4725a468fa20add9034efd109975b9fc7ec51d1 | |||
| b9cf8d7bbad5dcd74a8a91b6d6439f314b540db5 | |||
There was a problem hiding this comment.
If this is merged after #2130, this should be changed to be301c4b17044e08bf5fb01395804816ee950957.
My idea was to merge this before the renaming PR, because the commit fixing the monorepo tests is already in the branch. So I'd fix those in #2127 |
Ah, I somehow thought the rename PR was already merged. OK, then just fix the wrong comments and we're ready to go! |
karlb
approved these changes
Jun 16, 2023
palango
force-pushed
the
palango/full-node-incentives
branch
from
12248be
to
a22e49a
Compare
palango
force-pushed
the
palango/full-node-incentives
branch
from
a22e49a
to
ecf2e94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deprecating the gateway fee.
--light.gatewayfeeargumentGatewayFeeRecipientorGatewayFeeGatewayFeeRecipientorGatewayFeeThis doesn't include changes to the LES protocol yet, as those can be done independently of a hardfork and are therefore not time sensitive.