Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename gfork to gingerbread #2127

Merged
merged 4 commits into from
Jun 20, 2023
Merged

Rename gfork to gingerbread #2127

merged 4 commits into from
Jun 20, 2023

Conversation

palango
Copy link
Contributor

@palango palango commented Jun 13, 2023

Description

  • Give the hardfork it's proper name
  • Adapt the override.espresso flag to gingerbread

@github-actions
Copy link

github-actions bot commented Jun 13, 2023

Coverage from tests in ./e2e_test/... for ./consensus/istanbul/... at commit 0fbd1f2

coverage: 49.2% of statements across all listed packages
coverage:  60.0% of statements in consensus/istanbul
coverage:  40.1% of statements in consensus/istanbul/announce
coverage:  54.5% of statements in consensus/istanbul/backend
coverage:   0.0% of statements in consensus/istanbul/backend/backendtest
coverage:  24.3% of statements in consensus/istanbul/backend/internal/replica
coverage:  63.5% of statements in consensus/istanbul/core
coverage:  45.0% of statements in consensus/istanbul/db
coverage:   0.0% of statements in consensus/istanbul/proxy
coverage:  64.4% of statements in consensus/istanbul/uptime
coverage:  51.8% of statements in consensus/istanbul/validator
coverage:  79.2% of statements in consensus/istanbul/validator/random

@palango palango marked this pull request as ready for review June 13, 2023 14:11
@github-actions
Copy link

github-actions bot commented Jun 13, 2023

5825 passed, 44 skipped

@palango palango requested a review from karlb June 13, 2023 15:15
@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Patch coverage: 64.80% and project coverage change: +1.06 🎉

Comparison is base (71bdbcf) 54.30% compared to head (a148e25) 55.36%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2127      +/-   ##
==========================================
+ Coverage   54.30%   55.36%   +1.06%     
==========================================
  Files         692      675      -17     
  Lines      115642   113665    -1977     
==========================================
+ Hits        62795    62927     +132     
+ Misses      49014    46911    -2103     
+ Partials     3833     3827       -6     
Impacted Files Coverage Δ
cmd/devp2p/internal/ethtest/transaction.go 0.00% <0.00%> (ø)
cmd/geth/chaincmd.go 0.00% <0.00%> (ø)
cmd/geth/config.go 0.00% <0.00%> (ø)
cmd/geth/main.go 21.39% <ø> (+0.91%) ⬆️
cmd/geth/usage.go 10.90% <ø> (ø)
cmd/utils/flags.go 2.56% <0.00%> (ø)
consensus/istanbul/utils.go 47.10% <ø> (+1.13%) ⬆️
contracts/currency/currency.go 55.00% <ø> (ø)
contracts/election/election.go 25.00% <ø> (ø)
contracts/epoch_rewards/epoch_rewards.go 88.88% <ø> (ø)
... and 56 more

... and 35 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@karlb karlb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure how the overrides are used, so I can't judge if the override should be switched from espresso to gingerbread. Apart from that, it looks good!

core/vm/jump_table.go Show resolved Hide resolved
@palango
Copy link
Contributor Author

palango commented Jun 16, 2023

Failing tests will pass once #2130 is merged.

This one existed for espresso as well and was just
adapted to gingerbread.
Use updated version of the monorepo, which includes an update
to `node-gyp` which in turn allows us to use python 3.9
@palango palango enabled auto-merge (squash) June 20, 2023 11:53
@palango palango merged commit 64ac925 into master Jun 20, 2023
@palango palango deleted the palango/gingerbread branch June 20, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants