-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename gfork to gingerbread #2127
Conversation
Coverage from tests in coverage: 49.2% of statements across all listed packagescoverage: 60.0% of statements in consensus/istanbul coverage: 40.1% of statements in consensus/istanbul/announce coverage: 54.5% of statements in consensus/istanbul/backend coverage: 0.0% of statements in consensus/istanbul/backend/backendtest coverage: 24.3% of statements in consensus/istanbul/backend/internal/replica coverage: 63.5% of statements in consensus/istanbul/core coverage: 45.0% of statements in consensus/istanbul/db coverage: 0.0% of statements in consensus/istanbul/proxy coverage: 64.4% of statements in consensus/istanbul/uptime coverage: 51.8% of statements in consensus/istanbul/validator coverage: 79.2% of statements in consensus/istanbul/validator/random |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2127 +/- ##
==========================================
+ Coverage 54.30% 55.36% +1.06%
==========================================
Files 692 675 -17
Lines 115642 113665 -1977
==========================================
+ Hits 62795 62927 +132
+ Misses 49014 46911 -2103
+ Partials 3833 3827 -6
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure how the overrides are used, so I can't judge if the override should be switched from espresso to gingerbread. Apart from that, it looks good!
3563c78
to
0bd998b
Compare
Failing tests will pass once #2130 is merged. |
0bd998b
to
bc77a62
Compare
This one existed for espresso as well and was just adapted to gingerbread.
Use updated version of the monorepo, which includes an update to `node-gyp` which in turn allows us to use python 3.9
7556bdb
to
a148e25
Compare
Description
override.espresso
flag to gingerbread