Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade python to 3.10 #2133

Closed
wants to merge 2 commits into from
Closed

Upgrade python to 3.10 #2133

wants to merge 2 commits into from

Conversation

palango
Copy link
Contributor

@palango palango commented Jun 20, 2023

Description

A few sentences describing the overall effects and goals of the pull request's commits.
What is the current behavior, and what is the updated/expected behavior with this PR?

Other changes

Describe any minor or "drive-by" changes here.

Tested

An explanation of how the changes were tested or an explanation as to why they don't need to be.

Related issues

  • Fixes #[issue number here]

Backwards compatibility

Brief explanation of why these changes are/are not backwards compatible.

@github-actions
Copy link

Coverage from tests in ./e2e_test/... for ./consensus/istanbul/... at commit ff0fa1a

coverage: 50.0% of statements across all listed packages
coverage:  60.4% of statements in consensus/istanbul
coverage:  42.7% of statements in consensus/istanbul/announce
coverage:  55.7% of statements in consensus/istanbul/backend
coverage:   0.0% of statements in consensus/istanbul/backend/backendtest
coverage:  24.3% of statements in consensus/istanbul/backend/internal/replica
coverage:  63.4% of statements in consensus/istanbul/core
coverage:  50.0% of statements in consensus/istanbul/db
coverage:   0.0% of statements in consensus/istanbul/proxy
coverage:  64.4% of statements in consensus/istanbul/uptime
coverage:  51.8% of statements in consensus/istanbul/validator
coverage:  79.2% of statements in consensus/istanbul/validator/random

@github-actions
Copy link

5823 passed, 2 failed, 44 skipped

Test failures:
  TestUpdatedKeyfileContents: keystore
    account_cache_test.go:393: Emptying account file failed
account_cache_test.go:394: wasn't notified of new accounts
  TestEthersJSCompatibility: e2e_test
Checking getExchangeSpenders. spenders = [0x000000000000000000000000000000000000d028]
Checking medianRate. numerator = 1000000000000000000000000  denominator = 1000000000000000000000000 
Checking gas price minimum. cusdValue = 100000000
executing mocha test with /usr/bin/npm run test --networkaddr=http://127.0.0.1:44573 --blocknum=0x0 -- --grep ethers.js compatibility tests with state

ethersjs-api-check@1.0.0 test /runner/_work/celo-blockchain/celo-blockchain/e2e_test/ethersjs-api-check
mocha -r ts-node/register test/*.ts "--grep" "ethers.js compatibility tests with state"

ethers.js compatibility tests with state
✔ provider.getBlock works (block has gasLimit set) (50ms)
✔ EIP-1559 transactions supported (can get feeData)
✔ block has gasLimit
✔ block has baseFeePerGas

4 passing (105ms)

e2e_test.go:571: </code></pre></td></tr>
This test report was produced by the test-summary action.  Made with ❤️ in Cambridge.

@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Patch coverage: 65.06% and project coverage change: +1.03 🎉

Comparison is base (71bdbcf) 54.30% compared to head (3fca039) 55.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2133      +/-   ##
==========================================
+ Coverage   54.30%   55.33%   +1.03%     
==========================================
  Files         692      675      -17     
  Lines      115642   113665    -1977     
==========================================
+ Hits        62795    62902     +107     
+ Misses      49014    46931    -2083     
+ Partials     3833     3832       -1     
Impacted Files Coverage Δ
cmd/devp2p/internal/ethtest/transaction.go 0.00% <0.00%> (ø)
cmd/geth/chaincmd.go 0.00% <0.00%> (ø)
cmd/geth/main.go 21.39% <ø> (+0.91%) ⬆️
cmd/geth/usage.go 10.90% <ø> (ø)
cmd/utils/flags.go 2.56% <0.00%> (ø)
consensus/istanbul/utils.go 47.10% <ø> (+1.13%) ⬆️
contracts/currency/currency.go 55.00% <ø> (ø)
contracts/election/election.go 25.00% <ø> (ø)
contracts/epoch_rewards/epoch_rewards.go 88.88% <ø> (ø)
contracts/freezer/freezer.go 70.00% <ø> (ø)
... and 51 more

... and 26 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@palango palango closed this Jun 20, 2023
@palango palango deleted the palango/python branch June 22, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant