From eb8b37cfc602019c304025ed4a6005e300285dac Mon Sep 17 00:00:00 2001 From: Martin Date: Thu, 12 Sep 2024 21:16:06 +0200 Subject: [PATCH 1/3] Add CGP 149: decrease constitution for GoldToken.increaseAllowance (#482) * Add CGP 149: decrease constitution for GoldToken.increaseAllowance * Add forum link * Add forum link in frontmatter --------- Co-authored-by: 0xj4an (Work Account) <111611644+work-0xj4an@users.noreply.github.com> --- CGPs/cgp-0149.md | 77 ++++++++++++++++++++++++++++++++++++++ CGPs/cgp-0149/mainnet.json | 13 +++++++ 2 files changed, 90 insertions(+) create mode 100644 CGPs/cgp-0149.md create mode 100644 CGPs/cgp-0149/mainnet.json diff --git a/CGPs/cgp-0149.md b/CGPs/cgp-0149.md new file mode 100644 index 0000000..181153b --- /dev/null +++ b/CGPs/cgp-0149.md @@ -0,0 +1,77 @@ +--- +cgp: 149 +title: 'Decrease `constitution` parameter for `GoldToken.increaseAllowance`' +date-created: 2024-09-10 +author: 'Martin Chrzanowski (@m-chrzan)' +status: DRAFT +discussions-to: https://forum.celo.org/t/decrease-constitution-parameter-for-goldtoken-increaseallowance/9002 +governance-proposal-id: +date-executed: +--- + +## Overview + +This proposal is to decrease the `constitution` parameter (the parameter that +determines what percentage of YES votes are necessary for a Celo Governance +proposal to pass) of `GoldToken.increaseAllowance` from 90% to 60%. This is in +line with the `constitution` parameter of `GoldToken.approve`. + +### Status + +- DRAFT = Feedback collection + +### Proposal Description + +The Governance contract defines `constitution` parameters that dictate what +percentage of votes need to be YES votes for a CGP to pass. In general more +risky functions (that affect important protocol parameters or access to +community funds) should have a higher threshold (think how in e.g. US Congress, +some things require a simple 50% majority, others a 2/3rds "super majority"). + +At mainnet launch, the cLabs team proposed `constitution` parameters for most +core contract functions. For some reason `GoldToken.increaseAllowance` was +missing in this initial configuration, so its difficulty is based on the default +for the GoldToken contract - 90%. `GoldToken.approve` was set explicitly to 60%. + +As `increaseAllowance` is very similar in behavior to `approve` (if anything, +it's less risky than `approve`), this proposal aims to set its `constitution` +parameter to 60%, reducing from the current 90%. It appears that setting a +similar parameter for `increaseAllowance` was simply missed by the dev team when +proposing the initial Governance configuration. + +## Proposed Changes + +1. Set the constitution parameter. + - Destination: Governance + - Data: setConstitution(GoldTokenProxy, increaseAllowance.functionSelector, 60%) + - Value: 0 + +## Verification + +Once the proposal is proposed on chain, fetch it with + + celocli governance:show --proposalID --node https://forno.celo.org + +Verify that: + +- The proposal has value 0 (no CELO should be transferred). +- There is one transaction in the proposal. +- The transaction destination is the Governance contract + (`0xD533Ca259b330c7A88f74E000a3FaEa2d63B7972`, verify against [Celo +docs](https://docs.celo.org/contract-addresses)). +- The transaction payload is a call to `setConstitution` with parameters: + - Address of the CELO token contract + (`0x471EcE3750Da237f93B8E339c536989b8978a438`, verify against [Celo +docs](https://docs.celo.org/token-addresses)). + - The function selector for `increaseAllowance` (`0x39509351`) + - 60% written as a Fixidity value (`600000000000000000000000` or `6e23`). + +## Risks + +This proposal will make governance proposals with `GoldToken.increaseAllowance` +easier to pass, but they will still be as difficult to pass as proposals with +`GoldToken.approve`, which has a similar risk profile. + +## Useful Links + +* [Forum Post](https://forum.celo.org/t/decrease-constitution-parameter-for-goldtoken-increaseallowance/9002) diff --git a/CGPs/cgp-0149/mainnet.json b/CGPs/cgp-0149/mainnet.json new file mode 100644 index 0000000..54234c3 --- /dev/null +++ b/CGPs/cgp-0149/mainnet.json @@ -0,0 +1,13 @@ +[ + { + "contract": "GovernanceProxy", + "address": "0xD533Ca259b330c7A88f74E000a3FaEa2d63B7972", + "function": "setConstitution", + "args": [ + "0x471EcE3750Da237f93B8E339c536989b8978a438", + "0x39509351", + "600000000000000000000000" + ], + "value": "0" + } +] From 99fcc24adae4ad6c4b2d980fcf0e687f155f6546 Mon Sep 17 00:00:00 2001 From: "0xj4an (Work Account)" <111611644+work-0xj4an@users.noreply.github.com> Date: Thu, 12 Sep 2024 14:18:09 -0500 Subject: [PATCH 2/3] Update cgp-0132.md (#480) Co-authored-by: zoz <97761083+0xzoz@users.noreply.github.com> --- CGPs/cgp-0132.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/CGPs/cgp-0132.md b/CGPs/cgp-0132.md index 785a17f..4795dee 100644 --- a/CGPs/cgp-0132.md +++ b/CGPs/cgp-0132.md @@ -3,10 +3,10 @@ cgp: 132 title: Proposal for Funding Stabila - Driving Stablecoin Adoption on Celo date-created: 2024-04-26 author: "Kevin Tharayil (@KevinTharayil)" -status: EXPIRED +status: EXECUTED discussions-to: https://forum.celo.org/t/final-proposal-for-funding-stabila-driving-stablecoin-adoption-on-celo/7810 -governance-proposal-id: 173 -date-executed: +governance-proposal-id: 176 +date-executed: 2024-05-17 --- ## Overview of Stabila Proposal From 6d7b8d6219f08905ab1ca3a569b24cb9fda73e87 Mon Sep 17 00:00:00 2001 From: "0xj4an (Work Account)" <111611644+work-0xj4an@users.noreply.github.com> Date: Fri, 13 Sep 2024 04:01:47 -0500 Subject: [PATCH 3/3] Update README.md with last Gov Call (#483) * Update README.md with last Gov Call * Update README.md * Update README.md * Update next Gov Call #53 * Fix Typo --------- Co-authored-by: zoz <97761083+0xzoz@users.noreply.github.com> --- README.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index d1d0f4b..c08afee 100644 --- a/README.md +++ b/README.md @@ -20,8 +20,9 @@ We regularly hold governance calls to discuss proposals. See below for a summary | № | Date | Agenda | Notes | Recording | |:---:|:---------------:|:------:|:-----:|:---------:| -| 52 | Sep 12, 2024 | [Agenda](https://github.com/celo-org/governance/issues/477) | [Notes - TBU]() | [Video - TBU]() | -| 51 | Aug 29, 2024 | [Agenda](https://github.com/celo-org/governance/issues/461) | [Notes](https://docs.google.com/document/d/1je3PdVWG0yKlRsADcdiDVGB_kxIuHND5leArmWY668I) | [Video](https://drive.google.com/drive/u/1/folders/1qQgL5kZCl3hvQQRoM7QRySy2thDBqjPe) | +| 53 | Oct 3, 2024 | [Agenda](https://github.com/celo-org/governance/issues/484) | [Notes - TBU]() | [Video-TBU]() | +| 52 | Sep 12, 2024 | [Agenda](https://github.com/celo-org/governance/issues/477) | [Notes](https://docs.google.com/document/d/17G97Lp5D-X0bd8lOLlJOKKnuUmwzNUzshSYywazmgvk) | [Video](https://drive.google.com/file/d/1F755lHFL6ZbYBcN0pBspofyRyesRYejp) | +| 51 | Aug 29, 2024 | [Agenda](https://github.com/celo-org/governance/issues/461) | [Notes](https://docs.google.com/document/d/1je3PdVWG0yKlRsADcdiDVGB_kxIuHND5leArmWY668I) | [Video](https://drive.google.com/file/d/1sy1oZr6oi3bKqx9tIonHzH1vnlrBE_9g) | | 50 | Aug 1, 2024 | [Agenda](https://github.com/celo-org/governance/issues/457) | [Notes](https://docs.google.com/document/d/1XXeOTnk-q0LTMUOI_EYnDqLjiOxf9DO8RU7crICMvGw) | [Video](https://drive.google.com/file/d/1Ny3FNQaOusTd1wmjX3-V8cZsiztyE6bH) | | 49 | Jul 18, 2024 | [Agenda](https://github.com/celo-org/governance/issues/455) | [Notes](https://docs.google.com/document/d/1M160EsHhPMNG2XSY-66AZsag3qBlT-dTSchH73eY33s) | [Video](https://drive.google.com/file/d/1fstTldC8xGanauyLUkgqf37T_fGqUfyX) | | 48 | Jun 27, 2024 | [Agenda](https://github.com/celo-org/governance/issues/446) | [Notes](https://docs.google.com/document/d/1z_xOyi9uPaMw0Fb1RbAlBZoi0FhfnTEn5mdNDin6FsM) | N/A |