-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CGP-131 #411
CGP-131 #411
Conversation
Co-authored-by: Martín Volpe <volpe@clabs.co>
Co-authored-by: Martín Volpe <volpe@clabs.co>
@martinvol CGP 127 is already taken by another proposal made by you the USDC proposal. Please change this one to 128 to be able to merge it. |
@martinvol CGP 128 is already taken by another proposal made by you the USDT proposal. |
…rnance into pahor/updateDelegateeCount
…rnance into pahor/updateDelegateeCount
status: DRAFT | ||
discussions-to: https://forum.celo.org/t/celo-protocol-upgrades-gingerbread-hard-fork-and-contracts-release-10/6612 | ||
governance-proposal-id: 170 | ||
date-executed: 2050-01-01 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Despite the many new checks, people keep finding creative ways to submit invalid data. @martinvol if the status is draft, then the date-executed cannot be anything but empty, since it refers to the date that the proposal gets executed on chain. Whatever that date is, it's certainly not 2050-01-01
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making sure proposals shouldn't have formatting errors should be responsability of the editors, they approved and merged the change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do agree!
No description provided.