Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CGP-131 #411

Merged
merged 17 commits into from
Apr 4, 2024
Merged

CGP-131 #411

merged 17 commits into from
Apr 4, 2024

Conversation

pahor167
Copy link
Contributor

No description provided.

CGPs/cgp-0127.md Outdated Show resolved Hide resolved
CGPs/cgp-0127.md Outdated Show resolved Hide resolved
CGPs/cgp-0127.md Outdated Show resolved Hide resolved
CGPs/cgp-0127.md Outdated Show resolved Hide resolved
martinvol and others added 3 commits March 26, 2024 15:21
Co-authored-by: Martín Volpe <volpe@clabs.co>
Co-authored-by: Martín Volpe <volpe@clabs.co>
@work-0xj4an
Copy link
Member

@martinvol CGP 127 is already taken by another proposal made by you the USDC proposal. Please change this one to 128 to be able to merge it.

CGPs/cgp-0127.md Outdated Show resolved Hide resolved
@work-0xj4an
Copy link
Member

work-0xj4an commented Apr 4, 2024

@martinvol CGP 128 is already taken by another proposal made by you the USDT proposal.
Please change this one to CGP-0131 to be able to merge it. (We have PR for 129 and 130 already)

@martinvol martinvol changed the title CGP-127 CGP-129 Apr 4, 2024
@work-0xj4an work-0xj4an changed the title CGP-129 CGP-131 Apr 4, 2024
@work-0xj4an work-0xj4an merged commit 3deea76 into main Apr 4, 2024
5 checks passed
@work-0xj4an work-0xj4an deleted the pahor/updateDelegateeCount branch April 4, 2024 19:18
status: DRAFT
discussions-to: https://forum.celo.org/t/celo-protocol-upgrades-gingerbread-hard-fork-and-contracts-release-10/6612
governance-proposal-id: 170
date-executed: 2050-01-01
Copy link
Collaborator

@jmrossy jmrossy Apr 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Despite the many new checks, people keep finding creative ways to submit invalid data. @martinvol if the status is draft, then the date-executed cannot be anything but empty, since it refers to the date that the proposal gets executed on chain. Whatever that date is, it's certainly not 2050-01-01

Copy link
Contributor

@martinvol martinvol Apr 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making sure proposals shouldn't have formatting errors should be responsability of the editors, they approved and merged the change

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do agree!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants