Skip to content

Commit

Permalink
ci(gh workflows): review workflows in direction of new vars
Browse files Browse the repository at this point in the history
  • Loading branch information
KaiSchwarz-cnic committed Oct 12, 2023
1 parent c98cf69 commit f749236
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 10 deletions.
13 changes: 13 additions & 0 deletions .classpath
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,19 @@
<attribute name="m2e-apt" value="true"/>
</attributes>
</classpathentry>
<classpathentry excluding="**" kind="src" output="target/classes" path="src/main/resources">
<attributes>
<attribute name="maven.pomderived" value="true"/>
<attribute name="optional" value="true"/>
</attributes>
</classpathentry>
<classpathentry excluding="**" kind="src" output="target/test-classes" path="src/test/resources">
<attributes>
<attribute name="maven.pomderived" value="true"/>
<attribute name="test" value="true"/>
<attribute name="optional" value="true"/>
</attributes>
</classpathentry>
<classpathentry kind="src" output="target/test-classes" path="target/generated-test-sources/test-annotations">
<attributes>
<attribute name="optional" value="true"/>
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ jobs:
persist-credentials: false
- uses: actions/setup-java@v3
with:
java-version: "18"
distribution: "adopt"
java-version: ${{ vars.RTLDEV_MW_CI_JAVA_VERSION }}
distribution: ${{ vars.RTLDEV_MW_CI_JAVA_DISTRO }}
- name: Setup NodeJS ${{ vars.RTLDEV_MW_CI_NODE_VERSION }}
uses: actions/setup-node@v3
with:
Expand Down
14 changes: 6 additions & 8 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ on:
jobs:
# separate job to set as required in branch protection,
# as the build names above change each time Node versions change
test:
lint:
name: Linting
runs-on: ubuntu-latest
steps:
Expand All @@ -35,16 +35,14 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

test_matrix:
runs-on: ubuntu-latest

strategy:
matrix:
java-version:
- 16
- 17
- 18
java-version: ${{ fromJson(vars.RTLDEV_MW_CI_JAVA_MATRIX) }}

runs-on: ubuntu-latest
needs: test
name: Test @ Java JDK ${{ matrix.java-version }}
needs: lint

steps:
- name: Checkout
Expand All @@ -56,7 +54,7 @@ jobs:
uses: actions/setup-java@v3
with:
java-version: ${{ matrix.java-version }}
distribution: "temurin"
distribution: ${{ vars.RTLDEV_MW_CI_JAVA_DISTRO }}
- name: Validate & Coverage Report
run: |
mvn -B clean site package
Expand Down

0 comments on commit f749236

Please sign in to comment.