Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase the diagonal wire version #199

Merged
merged 34 commits into from
Mar 15, 2024
Merged

Increase the diagonal wire version #199

merged 34 commits into from
Mar 15, 2024

Conversation

myliu-hub
Copy link
Contributor

Inclined wire version added：

  1. The location of the XML file for the diagonal wire version of the separate drift chamber is Detector/DetDriftChamber/compact/det_inclined_wire.xml ;
  2. The location of the XML file is Detector/DetCRD/compact/CRD_common_v01/DC_Simple_v01_03.xml ;
  3. Alpha is 12 degrees ;

@myliu-hub
Copy link
Contributor Author

@mirguest @ihepzhangyao @fucd Hi everyone, please check if it is correct

@fucd
Copy link
Contributor

fucd commented Oct 29, 2021 •
edited
Loading

@myliu-hub Hi Mengyao, thanks for update. Just one comment: the key "Simple" can be changed to another word now, since the drift chamber seems complete now. DC_Xxx_v01_01.xml can be created. And one thing should be confirmed. I remove region="DriftChamberRegion" in Detector/DetCRD/compact/CRD_common_v01/DC_Simple_v01_02.xml in order to rub job because of API model. If it does not work still, it should be removed also in new compact file temporarily.

@myliu-hub
Copy link
Contributor Author

@fucd Hi, I have changed it according to your request, do you think it is okay?

@mirguest
Copy link
Member

Hi @myliu-hub ,
I have a quick look at your PR. It looks like you duplicate the detector constructor c++ code. It will cause problems, especially when you need to synchronize parameters or implementations between the two constructors.
Actually the only difference is how to construct the layer and wire. I would suggest you to only maintain one c++ constrcutor and you can use some software design to reduce such problem.
Tao

@fucd
Copy link
Contributor

fucd commented Nov 1, 2021

@myliu-hub Thank you for update. I have no more comments now.

@fucd Hi, I have changed it according to your request, do you think it is okay?

@wenxingfang
Copy link
Contributor

@ihepzhangyao @mirguest This PR seems quite important, should we merge it?

ihepzhangyao
ihepzhangyao reviewed Aug 18, 2022
View reviewed changes
Detector/DetCRD/compact/CRD_o1_v01/CRD_o1_v01-onlyTracker.xml Outdated
@@ -32,7 +32,7 @@
<include ref="../CRD_common_v01/VXD_v01_01.xml"/>
<include ref="../CRD_common_v01/FTD_SkewRing_v01_01.xml"/>
<include ref="../CRD_common_v01/SIT_SimplePixel_v01_01.xml"/>
<include ref="../CRD_common_v01/DC_Simple_v01_02.xml"/>
<include ref="../CRD_common_v01/DC_Simple_v01_03.xml"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find DC_Simple_v01_03.xml. Could you please double check?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @myliu-hub , could you reply Yao's comment?

Detector/DetCRD/compact/CRD_o1_v02/CRD_o1_v02-onlyTracker.xml Outdated
@@ -31,7 +31,7 @@
<include ref="../CRD_common_v01/VXD_v01_01.xml"/>
<include ref="../CRD_common_v01/FTD_SkewRing_v01_01.xml"/>
<include ref="../CRD_common_v01/SIT_SimplePixel_v01_01.xml"/>
<include ref="../CRD_common_v01/DC_Simple_v01_01.xml"/>
<include ref="../CRD_common_v01/DC_Simple_v01_03.xml"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DC_Simple_v01_03.xml is missing?

@ihepzhangyao
Copy link
Contributor

ihepzhangyao commented Aug 18, 2022 •
edited
Loading

Could you please post a set of performance based on this branch?

@fucd
Copy link
Contributor

fucd commented Sep 5, 2022

@myliu-hub How about now? I also hope it can be merged. After finish this, can you add extensiton data into DC DetElement, just like TPC?

@myliu-hub
Copy link
Contributor Author

This request has been updated in several aspects:

  1. The version of RecGenfitAlgSDT algorithm is updated to the latest
  2. The drift chamber of stero wire and straight wire can be constructed using the same source file. It only needs to modify the XML file. In the XML file, the skew Angle can be set to 0 degrees or up to 12 degrees.
  3. Updated track reconstruction algorithm, Silicon detector and drift chamber can be combined measurement，Reconstruction/RecGenfitAlg/src/RecGenfitAlgSDT.cpp
  4. Run the script Examples/options/tut_detsim_rec_SDT.py ，you can check the algorithm.

Here is the result of track fitting(single particle):

  1. Momentum resolution：
    pt100
  2. Spatial resolution(110um)：

图片1

3. Mass of higgs(e+e- ->ZH, H -> mu+mu-):

MassH (2)

ihepzhangyao
ihepzhangyao reviewed Mar 15, 2024
View reviewed changes
Copy link
Contributor

@ihepzhangyao ihepzhangyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some commit to your code.

Detector/DetDriftChamber/src/driftchamber/DriftChamber.cpp Outdated
@@ -1,12 +1,3 @@
//====================================================================
// Detector description implementation of the Drift Chamber
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the file description.

Digitisers/DCHDigi/src/DCHDigiAlg.h
@@ -54,38 +56,51 @@ class DCHDigiAlg : public GaudiAlgorithm
NTuple::Array<int > m_cell ;
NTuple::Array<float> m_cell_x ;
NTuple::Array<float> m_cell_y ;
NTuple::Array<float> m_cell1_x ;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the difference between cell and cell1. Could you please add a commit?

ihepzhangyao
ihepzhangyao reviewed Mar 15, 2024
View reviewed changes
Copy link
Contributor

@ihepzhangyao ihepzhangyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All review have been cleared

@mirguest mirguest merged commit 8408ec0 into cepc:master Mar 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihepzhangyao ihepzhangyao ihepzhangyao approved these changes

@mirguest mirguest mirguest approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@myliu-hub @fucd @mirguest @wenxingfang @ihepzhangyao