Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protobufjs Prototype Pollution vulnerability (CVE-2023-36665) #591

Closed
NormandoHall opened this issue Jul 10, 2023 · 2 comments · Fixed by #596
Closed

protobufjs Prototype Pollution vulnerability (CVE-2023-36665) #591

NormandoHall opened this issue Jul 10, 2023 · 2 comments · Fixed by #596

Comments

@NormandoHall
Copy link

NormandoHall commented Jul 10, 2023

npm audit report

protobufjs 6.10.0 - 7.2.3
Severity: high
protobufjs Prototype Pollution vulnerability - GHSA-h755-8qp9-cq85
No fix available
node_modules/protobufjs
@cerbos/grpc *
Depends on vulnerable versions of protobufjs
node_modules/@cerbos/grpc

2 high severity vulnerabilities

Some issues need review, and may require choosing
a different dependency.

@haines haines changed the title Security advice protobufjs Prototype Pollution vulnerability (CVE-2023-36665) Jul 11, 2023
@haines
Copy link
Member

haines commented Jul 11, 2023

Hi @NormandoHall, thanks for reporting this. This vulnerability does not affect @cerbos/grpc because it relates to parsing untrusted .proto files. We only rely on protobufjs for serialization and deserialization of the protobuf binary wire format, which is unrelated.

We will update to protobufjs 7.2.4 to silence this false positive as soon as possible. We inherit the dependency from ts-proto, and work is underway there to update to the fixed version (stephenh/ts-proto#834, stephenh/ts-proto#874). Once that is merged and released, I'll cut a new release of @cerbos/grpc with the updated dependency.

@NormandoHall
Copy link
Author

Thank you @haines for the clarification, and for Cerbos!

@haines haines linked a pull request Jul 13, 2023 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants