chore: Lay groundwork for policy file loading #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Haines <haines@cerbos.dev>
Signed-off-by: Andrew Haines <haines@cerbos.dev>
alexolivier
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR lays the groundwork for a new package
@cerbos/filesthat loads policies from YAML or JSON files, by separating the code generation templates per package (because@cerbos/filesonly needs to generate thePolicytypes) and exporting the policy conversion function from@cerbos/core(it's marked internal because it is only intended to be used by@cerbos/files).As a side effect, this cleans up a bunch of unused generated code from
@cerbos/lite, which contained code for the Admin API despite not implementing it.Protos are now kept in the repository so that the code generation is reproducible (previously we always generated from the latest cerbos/cerbos commit).