fix: use upstream node-sql-parser package #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Published beta package version: |
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: @lucianbuzzo/node-sql-parser@4.6.6 |
SarjuHansaliya
approved these changes
Dec 9, 2023
There was a problem hiding this comment.
@LucianBuzzo I fixed some ts & linting issue but looks like its failing in integration tests
LucianBuzzo
force-pushed
the
lucianbuzzo/sql-parser
branch
from
bb8e3f0
to
73597a1
Compare
|
@SarjuHansaliya Oh I was literally working on this right now 😂 |
|
I'll take it from here |
This changes Yates to use the original upstream node-sql-parser package. The only reason Yates uses my fork is because at the time the `exprToSQL` method I contributed was not available in the general release. Fast-forward to 10 months later and my fork is now 499 commits behind master XD The only real difference that has to be made is the way that `$n` parameters are represented in the AST, but this is a simple change to make. Signed-off-by: Lucian Buzzo <lucian.buzzo@gmail.com>
Signed-off-by: Lucian Buzzo <lucian.buzzo@gmail.com>
Signed-off-by: Lucian Buzzo <lucian.buzzo@gmail.com>
LucianBuzzo
force-pushed
the
lucianbuzzo/sql-parser
branch
from
73597a1
to
91779eb
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes Yates to use the original upstream node-sql-parser package. The only reason Yates uses my fork is because at the time the
exprToSQLmethod I contributed was not available in the general release. Fast-forward to 10 months later and my fork is now 499 commits behind master XDThe only real difference that has to be made is the way that
$nparameters are represented in the AST, but this is a simple change to make.