Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

form: tab field layout improvements #62

Open
miguelgrc opened this issue Jul 2, 2024 · 0 comments
Open

form: tab field layout improvements #62

miguelgrc opened this issue Jul 2, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@miguelgrc
Copy link
Collaborator

miguelgrc commented Jul 2, 2024

Add some small improvements to the tab field:

  • See if we can remove the custom condition inFieldTemplate.jsx's render method
  • Check if the style in WrapIfAdditional.jsx:44 is needed
  • Change TabField.jsx so that either:
    • The tab sider is replaced by a select field when the width of the parent component (as opposed to the screen size that we are using now) is smaller than a threshold
    • Or modify our tab implementation so that nested tabs are displayed in the antd way, that is, as an expandable entry in the tabs sider that reveals the nested tabs in the sider itself with some indentation. Might be tricky in case we have a tab that inside has a normal field and another tab field (how do we display that normal field? the expandable item is not a tab by itself in antd, just a wrapper, and I don't know if it can be converted into one).
    • A third option is to support both: the second option in case we have a tab with only another tab field inside and the first one in case there is a tab field together with other items
@miguelgrc miguelgrc added the enhancement New feature or request label Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant