Skip to content

Commit

Permalink
Configure Sentry
Browse files Browse the repository at this point in the history
Added sentry as a dependency.
  • Loading branch information
Lorenzovagliano committed Oct 21, 2024
1 parent 5a98322 commit 0e4b789
Show file tree
Hide file tree
Showing 4 changed files with 30 additions and 7 deletions.
2 changes: 2 additions & 0 deletions dags/common/pull_ftp.py
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,8 @@ def _differential_pull(
sftp_files = s_ftp.list_files(excluded_directories=excluded_directories)
s3_files = repo.get_all_raw_filenames()
diff_files = list(filter(lambda x: x not in s3_files, sftp_files))
logger.msg("Differential")
logger.msg(diff_files)
return migrate_files(diff_files, s_ftp, repo, logger)


Expand Down
2 changes: 1 addition & 1 deletion requirements-airflow.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
-c https://raw.githubusercontent.com/apache/airflow/constraints-2.8.3/constraints-3.10.txt
apache-airflow[celery, postgres, redis, cncf.kubernetes]==2.8.3
apache-airflow[celery, postgres, redis, cncf.kubernetes, sentry]==2.8.3

16 changes: 12 additions & 4 deletions tests/integration/iop/test_iop_dag_pull_sftp.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
from iop.repository import IOPRepository
from iop.sftp_service import IOPSFTPService
from structlog import get_logger
import time

DAG_NAME = "iop_pull_sftp"

Expand Down Expand Up @@ -91,6 +92,7 @@ def test_dag_run(dag, dag_was_paused: bool, iop_empty_repo):


def test_dag_migrate_from_FTP(iop_empty_repo):
iop_empty_repo.delete_all()
assert len(iop_empty_repo.find_all()) == 0
with IOPSFTPService() as sftp:
migrate_from_ftp(
Expand Down Expand Up @@ -157,10 +159,16 @@ def test_dag_migrate_from_FTP(iop_empty_repo):
},
{"xml": "extracted/aca95c/aca95c.xml"},
]
for (file_from_repo, expected_file) in zip(
iop_empty_repo.find_all(), expected_files
):
assert file_from_repo == expected_file

assert len(iop_empty_repo.find_all()) == len(expected_files)

iop_pdf_files = sorted(item["pdf"] for item in iop_empty_repo.find_all() if "pdf" in item)
expected_pdf_files = sorted(item["pdf"] for item in expected_files if "pdf" in item)
assert iop_pdf_files == expected_pdf_files

iop_xml_files = sorted(item["xml"] for item in iop_empty_repo.find_all() if "xml" in item)
expected_xml_files = sorted(item["xml"] for item in expected_files if "xml" in item)
assert iop_xml_files == expected_xml_files


def test_dag_trigger_file_processing():
Expand Down
17 changes: 15 additions & 2 deletions tests/integration/iop/test_repo.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
from iop.sftp_service import IOPSFTPService
from pytest import fixture
from structlog import get_logger
import time


@fixture
Expand All @@ -13,6 +14,7 @@ def iop_empty_repo():


def test_pull_from_sftp(iop_empty_repo):
iop_empty_repo.delete_all()
with IOPSFTPService() as sftp:
migrate_from_ftp(
sftp,
Expand All @@ -30,6 +32,7 @@ def test_pull_from_sftp(iop_empty_repo):
}
}
)

expected_files = [
{
"pdf": "extracted/2022-07-30T03_02_01_content/1674-1137/1674-1137_46/1674-1137_46_8/1674-1137_46_8_085001/cpc_46_8_085001.pdf",
Expand Down Expand Up @@ -77,7 +80,17 @@ def test_pull_from_sftp(iop_empty_repo):
{"xml": "extracted/aca95c/aca95c.xml"},

]
assert iop_empty_repo.find_all() == expected_files

assert len(iop_empty_repo.find_all()) == len(expected_files)

iop_pdf_files = sorted(item["pdf"] for item in iop_empty_repo.find_all() if "pdf" in item)
expected_pdf_files = sorted(item["pdf"] for item in expected_files if "pdf" in item)
assert iop_pdf_files == expected_pdf_files

iop_xml_files = sorted(item["xml"] for item in iop_empty_repo.find_all() if "xml" in item)
expected_xml_files = sorted(item["xml"] for item in expected_files if "xml" in item)
assert iop_xml_files == expected_xml_files

assert sorted(iop_empty_repo.get_all_raw_filenames()) == sorted(
[
"2022-07-30T03_02_01_content.zip",
Expand All @@ -86,4 +99,4 @@ def test_pull_from_sftp(iop_empty_repo):
"2022-09-24T03_01_43_content.zip",
"aca95c.zip",
]
)
)

0 comments on commit 0e4b789

Please sign in to comment.