Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: update @rjsf/antd and use tooltips for descriptions #2760

Closed
miguelgrc opened this issue Mar 20, 2023 · 1 comment
Closed

ui: update @rjsf/antd and use tooltips for descriptions #2760

miguelgrc opened this issue Mar 20, 2023 · 1 comment
Assignees
Labels
admin-ui antd dependencies Pull requests that update a dependency file

Comments

@miguelgrc
Copy link
Contributor

miguelgrc commented Mar 20, 2023

Feature request

What is the expected behavior?
@rjsf/antd is updated to the latest version and tooltips are added to the PropKeyEditor and form fields.

What is motivation or use case for adding/changing the behavior?
There's this PR for @rjsf/antd which will allow to show descriptions as antd tooltips. We can take advantage of this in the PropKeyEditor and also by giving users the option to define a tooltip for their fields.

How should this be implemented in your opinion?
Update the dependency to the latest version. If it needs antd v5, it should be updated as well. Change descriptions in the PropKeyEditor to tooltips (at least in the cases in which it makes sense) and add a "Tooltip" field to let users specify a tooltip.

Are you willing to work on this yourself?
yes

@pamfilos
Copy link
Collaborator

closing as done here cern-sis/react-formule#16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admin-ui antd dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants