Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to pass in extra pod labels/annotations #270

Closed
wants to merge 3 commits into from

Conversation

aburan28
Copy link

@aburan28 aburan28 commented Feb 9, 2024

Addresses this issue #211

Signed-off-by: Adam Buran <aburan28@gmail.com>
Signed-off-by: Adam Buran <aburan28@gmail.com>
@jetstack-bot jetstack-bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Feb 9, 2024
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign joshvanl for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot
Copy link
Contributor

Hi @aburan28. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 9, 2024
@inteon
Copy link
Member

inteon commented Feb 9, 2024

/ok-to-test

@jetstack-bot jetstack-bot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 9, 2024
@inteon
Copy link
Member

inteon commented Feb 9, 2024

@aburan28 Please run "make generate" to update the README.md that is generated based on the values.yaml file.

Signed-off-by: Adam Buran <aburan28@gmail.com>
@aburan28
Copy link
Author

aburan28 commented Feb 9, 2024

Updated with the make generate output

@aburan28
Copy link
Author

aburan28 commented Feb 9, 2024

/retest

1 similar comment
@inteon
Copy link
Member

inteon commented Feb 13, 2024

/retest

@aburan28
Copy link
Author

Anything else needed for this PR?

@jetstack-bot jetstack-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 26, 2024
@jetstack-bot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot
Copy link
Contributor

@aburan28: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cert-manager-istio-csr-test-ecc 3286d13 link true /test pull-cert-manager-istio-csr-test-ecc

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cert-manager-prow
Copy link
Contributor

@aburan28: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cert-manager-istio-csr-istio-v1-19 3286d13 link true /test pull-cert-manager-istio-csr-istio-v1-19
pull-cert-manager-istio-csr-istio-v1-18 3286d13 link true /test pull-cert-manager-istio-csr-istio-v1-18
pull-cert-manager-istio-csr-istio-v1-15 3286d13 link true /test pull-cert-manager-istio-csr-istio-v1-15
pull-cert-manager-istio-csr-istio-v1-16 3286d13 link true /test pull-cert-manager-istio-csr-istio-v1-16
pull-cert-manager-istio-csr-istio-v1-14 3286d13 link true /test pull-cert-manager-istio-csr-istio-v1-14
pull-cert-manager-istio-csr-istio-v1-20 3286d13 link true /test pull-cert-manager-istio-csr-istio-v1-20
pull-cert-manager-istio-csr-istio-v1-17 3286d13 link true /test pull-cert-manager-istio-csr-istio-v1-17
pull-cert-manager-istio-csr-istio-v1-22 3286d13 link true /test pull-cert-manager-istio-csr-istio-v1-22
pull-cert-manager-istio-csr-istio-v1-21 3286d13 link true /test pull-cert-manager-istio-csr-istio-v1-21
pull-cert-manager-istio-csr-pure-runtime-config 3286d13 link true /test pull-cert-manager-istio-csr-pure-runtime-config
pull-cert-manager-istio-csr-istio-v1-23 3286d13 link true /test pull-cert-manager-istio-csr-istio-v1-23

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@SgtCoDFish
Copy link
Member

Closing this in favour of #372 - sorry this took a while to get around to @aburan28 !

@SgtCoDFish SgtCoDFish closed this Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants