-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a new CI image with Bazel #518
Conversation
/release-note-none |
Signed-off-by: irbekrm <irbekrm@gmail.com>
3947e0c
to
e0ccc66
Compare
/assign |
/test pull-testing-build |
@irbekrm: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've read the changes @irbekrm
But haven't tried to build the images or anything.
I can't tell where they'll be pushed nor how these and other jobs and images will eventually be used.
I'd recommend adding some comments in the jobs yaml file, the Dockerfile and elsewhere explaining how all these files are used....although I can see that the existing jobs don't have many comments either.
Or if you prefer, just /unhold
this and improve things later.
/lgtm
/hold
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: irbekrm, wallrj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks for the review Richard! Agree that the infra image building should be documented- I will do this separately in #520 since the process is the same for all of them. /hold cancel |
@irbekrm: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR builds a new image with Bazel, Docker, Node, Go for GitHub actions jobs that need to run Bazel.
This is mostly for the FIPS-compliant cert-manager building.
Signed-off-by: irbekrm irbekrm@gmail.com