Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a new CI image with Bazel #518

Merged
merged 1 commit into from
Jul 2, 2021

Conversation

irbekrm
Copy link
Contributor

@irbekrm irbekrm commented Jun 29, 2021

This PR builds a new image with Bazel, Docker, Node, Go for GitHub actions jobs that need to run Bazel.
This is mostly for the FIPS-compliant cert-manager building.

Signed-off-by: irbekrm irbekrm@gmail.com

@irbekrm irbekrm requested a review from SgtCoDFish June 29, 2021 07:34
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. area/testing Indicates a PR related to testing approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 29, 2021
@irbekrm
Copy link
Contributor Author

irbekrm commented Jun 29, 2021

/release-note-none

@jetstack-bot jetstack-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 29, 2021
Signed-off-by: irbekrm <irbekrm@gmail.com>
@JoshVanL
Copy link
Contributor

/assign

@irbekrm
Copy link
Contributor Author

irbekrm commented Jul 1, 2021

/test pull-testing-build

@jetstack-bot
Copy link
Contributor

@irbekrm: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test config
  • /test build
  • /test verify
  • /test pull-testing-check-testgrid-config

Use /test all to run all jobs.

In response to this:

/test pull-testing-build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@wallrj wallrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've read the changes @irbekrm

But haven't tried to build the images or anything.
I can't tell where they'll be pushed nor how these and other jobs and images will eventually be used.

I'd recommend adding some comments in the jobs yaml file, the Dockerfile and elsewhere explaining how all these files are used....although I can see that the existing jobs don't have many comments either.

Or if you prefer, just /unhold this and improve things later.

/lgtm
/hold

@jetstack-bot jetstack-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 2, 2021
@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 2, 2021
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irbekrm, wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@irbekrm
Copy link
Contributor Author

irbekrm commented Jul 2, 2021

Thanks for the review Richard!

Agree that the infra image building should be documented- I will do this separately in #520 since the process is the same for all of them.

/hold cancel

@jetstack-bot jetstack-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 2, 2021
@jetstack-bot jetstack-bot merged commit ff450bc into cert-manager:master Jul 2, 2021
@jetstack-bot
Copy link
Contributor

@irbekrm: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key testing-trusted.yaml using file config/jobs/testing/testing-trusted.yaml

In response to this:

This PR builds a new image with Bazel, Docker, Node, Go for GitHub actions jobs that need to run Bazel.
This is mostly for the FIPS-compliant cert-manager building.

Signed-off-by: irbekrm irbekrm@gmail.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@irbekrm irbekrm deleted the bazel_tools_image branch July 2, 2021 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/testing Indicates a PR related to testing dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants