-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add http serve to fuzzer #2343
Add http serve to fuzzer #2343
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, though after fixing the obvious c++ pedantic failure the fuzz test is still failing.
Is the way you are calling the test function OK ? No looping ? mgr_free right after test ?
v.len = k.len = 42; | ||
ASSERT(mg_commalist(&s2, &k, &v) == true); | ||
ASSERT(v.len == 0 && mg_vcmp(&k, "a") == 0); | ||
ASSERT(mg_commalist(&s2, &k, &v) == false); | ||
|
||
v.len = k.len = 42; | ||
ASSERT(mg_commalist(&s3, &k, &v) == true); | ||
ASSERT(v.len == 0 && mg_vcmp(&k, "a") == 0); | ||
v.len = k.len = 42; | ||
ASSERT(mg_commalist(&s3, &k, &v) == true); | ||
ASSERT(v.len == 0 && mg_vcmp(&k, "b") == 0); | ||
ASSERT(mg_commalist(&s3, &k, &v) == false); | ||
|
||
v.len = k.len = 42; | ||
ASSERT(mg_commalist(&s4, &k, &v) == true); | ||
ASSERT(mg_vcmp(&k, "a") == 0 && mg_vcmp(&v, "123") == 0); | ||
ASSERT(mg_commalist(&s4, &k, &v) == false); | ||
ASSERT(mg_commalist(&s4, &k, &v) == false); | ||
|
||
v.len = k.len = 42; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this magic number explained somewhere ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it is just a random number (the famous answer), just to make sure we're not re-using the result of the previous test.
No description provided.