Add OTA to the device dashboard. Implement for H5 #2370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpq
force-pushed
the
ota
branch
2 times, most recently
from
e290db7
to
8becad1
Compare
scaprile
approved these changes
Sep 5, 2023
There was a problem hiding this comment.
Is there a reason for the late Ethernet init ? All our examples do it early (as did this one before this commit)
mongoose/examples/stm32/nucleo-f746zg-make-baremetal-builtin/main.c
Lines 35 to 39 in d5b5cec
and the tutorial shows that...
Comment on lines
38
to
+42
| packed_fs.c: $(wildcard web_root/*) $(wildcard certs/*) Makefile web_root/main.css web_root/bundle.js | ||
| $(GZIP) web_root/* | ||
| $(CC) ../../test/pack.c -o $(PACK) | ||
| $(PACK) $(wildcard web_root/*) $(wildcard certs/*) > $@ | ||
| $(PACK) web_root/* certs/* > $@ | ||
| $(GZIP) -d web_root/* |
There was a problem hiding this comment.
In the fs tutorial I solved this with another rule... asterisks usually don't play nice in Windoze
Comment on lines
-38
to
+45
| ethernet_init(); // Initialise ethernet pins | ||
|
|
||
| MG_INFO(("Starting, CPU freq %g MHz", (double) SystemCoreClock / 1000000)); | ||
| struct mg_mgr mgr; // Initialise | ||
| mg_mgr_init(&mgr); // Mongoose event manager | ||
| mg_log_set(MG_LL_DEBUG); // Set log level | ||
|
|
||
| // Initialise Mongoose network stack | ||
| ethernet_init(); // Initialise ethernet pins |
There was a problem hiding this comment.
All other examples init Ethernet before fiddling with Mongoose.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.