Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nucleo-g031 baremetal example #2404

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Add nucleo-g031 baremetal example #2404

merged 1 commit into from
Oct 4, 2023

Conversation

cpq
Copy link
Member

@cpq cpq commented Oct 3, 2023

No description provided.

@cpq cpq requested a review from scaprile October 3, 2023 12:56
scaprile
scaprile requested changes Oct 3, 2023
View reviewed changes
Copy link
Collaborator

@scaprile scaprile left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can always make it prettier and commonize later.
2 things:

  • if we are using the W5500, all other examples that do that have "w5500" in their name.
  • why is mongoose.c file here so different ? I wouldn't merge this file as is, did you change the Makefile ?

@cpq cpq merged commit cb1ae31 into master Oct 4, 2023
116 checks passed
@cpq cpq deleted the g031 branch October 4, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scaprile scaprile scaprile requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cpq @scaprile