Single bank OTA #2446
Merged
Single bank OTA #2446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scaprile
reviewed
Nov 2, 2023
Comment on lines
+11
to
+20
| #define BTN PIN('C', 13) // User push button | ||
| #define LED1 PIN('B', 0) // On-board LED pin (green) | ||
| #define LED2 PIN('E', 1) // On-board LED pin (yellow) | ||
| #define LED3 PIN('B', 14) // On-board LED pin (red) | ||
| #define LED LED2 // Use yellow LED for blinking | ||
|
|
||
| #ifndef UART_DEBUG | ||
| #define UART_DEBUG USART3 | ||
| #endif | ||
|
|
There was a problem hiding this comment.
I like defines after includes, as it was before... just a matter of taste and having all necessary stuff at top
Plus, all hal.h have UART_DEBUG near the UART code
Comment on lines
+19
to
+24
| #define MG_LOG(level, args) \ | ||
| do { \ | ||
| if ((level) <= mg_log_level) { \ | ||
| mg_log_prefix((level), __FILE__, __LINE__, __func__); \ | ||
| mg_log args; \ | ||
| } \ |
There was a problem hiding this comment.
Cool.
I guess you couldn't resist temptation, a separate PR could have been nice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.