Add example for ch32v307 #2485
Merged
Add example for ch32v307 #2485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpq
force-pushed
the
ch32v307
branch
2 times, most recently
from
8dc9748
to
f7f968a
Compare
scaprile
reviewed
Nov 22, 2023
Comment on lines
+198
to
+200
| #ifdef __riscv | ||
| __attribute__((interrupt())) // For RISCV CH32V307, which share the same MAC | ||
| #endif |
There was a problem hiding this comment.
This compiler dependent, not only chip dependent
| @@ -209,8 +215,8 @@ void ETH_IRQHandler(void) { | |||
| if (++s_rxno >= ETH_DESC_CNT) s_rxno = 0; | |||
| } | |||
| } | |||
| ETH->DMASR = MG_BIT(7); // Clear possible RBUS while processing | |||
| ETH->DMARPDR = 0; // and resume RX | |||
| ETH->DMASR = ~0; // Clear flags | |||
There was a problem hiding this comment.
Please hide this q&d hack under some #ifdef
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.