Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: seeds #312

Merged
merged 5 commits into from
Aug 18, 2023
Merged

fix: seeds #312

merged 5 commits into from
Aug 18, 2023

Conversation

ruilopesm
Copy link
Member

No description provided.

@ruilopesm ruilopesm added bug Something isn't working backend Backend related labels Aug 13, 2023
@ruilopesm ruilopesm self-assigned this Aug 13, 2023
MarioRodrigues10
MarioRodrigues10 requested changes Aug 13, 2023
View reviewed changes
Copy link
Member

@MarioRodrigues10 MarioRodrigues10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When seeding accounts, admins were created with role student.
Also please seed with a random value of minimum and max entries on Session seeds

@MarioRodrigues10
Copy link
Member

Related to the second point, make sure it passes the constraint on #315 please 🙏

@ruilopesm
Copy link
Member Author

@MarioRodrigues10 Your first comment was fixed on #317.

@MarioRodrigues10
Copy link
Member

Alright, #317 is approved , make sure to update this branch and do what i asked in the 2nd comment 🙏

@ruilopesm ruilopesm changed the title Fix seeds fix: seeds Aug 17, 2023
MarioRodrigues10
MarioRodrigues10 approved these changes Aug 18, 2023
View reviewed changes
Copy link
Member

@MarioRodrigues10 MarioRodrigues10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job 🚀

@MarioRodrigues10 MarioRodrigues10 mentioned this pull request Aug 18, 2023
Merged
@ruilopesm ruilopesm added database Database related and removed backend Backend related labels Aug 18, 2023
@ruilopesm ruilopesm merged commit cdc6dd5 into develop Aug 18, 2023
3 checks passed
@ruilopesm ruilopesm deleted the rl/fix-seeds branch August 18, 2023 22:55
ruilopesm added a commit that referenced this pull request Aug 22, 2023
@ruilopesm
fix: seeds (#312)
38e1a06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarioRodrigues10 MarioRodrigues10 MarioRodrigues10 approved these changes

@joaodiaslobo joaodiaslobo Awaiting requested review from joaodiaslobo

@danielsp45 danielsp45 Awaiting requested review from danielsp45

@feliciofilipe feliciofilipe Awaiting requested review from feliciofilipe

@ruioliveira02 ruioliveira02 Awaiting requested review from ruioliveira02

Assignees

@ruilopesm ruilopesm

Labels
bug Something isn't working database Database related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ruilopesm @MarioRodrigues10