Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: schemas, contexts and migrations #318

Merged
merged 15 commits into from
Aug 23, 2023

Conversation

ruilopesm
Copy link
Member

No description provided.

@ruilopesm ruilopesm added enhancement New feature or improvements backend Backend related labels Aug 14, 2023
@ruilopesm ruilopesm self-assigned this Aug 14, 2023
@ruilopesm ruilopesm added the bug Something isn't working label Aug 14, 2023
@ruilopesm ruilopesm changed the title Fix & improve schemas, models and migrations fix: schemas, contexts and migrations Aug 17, 2023
@ruilopesm ruilopesm changed the title fix: schemas, contexts and migrations fix/refactor: schemas, contexts and migrations Aug 17, 2023
Copy link
Member

@MarioRodrigues10 MarioRodrigues10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There will be some problems in activities seeds due to changes in field types , some make sure to merge #312 first and then solve those issues before i approve this.
The rest of the code is looking good, that's only thing stopping me from approving this.

@ruilopesm ruilopesm changed the title fix/refactor: schemas, contexts and migrations refactor: schemas, contexts and migrations Aug 18, 2023
danielsp45
danielsp45 previously approved these changes Aug 22, 2023
@MarioRodrigues10 MarioRodrigues10 dismissed danielsp45’s stale review August 22, 2023 21:37

The rebase should be completed first, followed by solving any issues that may arise afterwards.

Copy link
Member

@MarioRodrigues10 MarioRodrigues10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a great work 🚀

@ruilopesm ruilopesm merged commit e369485 into develop Aug 23, 2023
3 checks passed
@ruilopesm ruilopesm deleted the rl/schemas-models-migrations branch August 23, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Backend related bug Something isn't working enhancement New feature or improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants