refactor: schemas, contexts and migrations #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruilopesm
requested review from
joaodiaslobo,
danielsp45,
feliciofilipe,
ruioliveira02 and
MarioRodrigues10
MarioRodrigues10
requested changes
Aug 14, 2023
ruilopesm
changed the title
ruilopesm
changed the title
MarioRodrigues10
requested changes
Aug 18, 2023
There was a problem hiding this comment.
There will be some problems in activities seeds due to changes in field types , some make sure to merge #312 first and then solve those issues before i approve this.
The rest of the code is looking good, that's only thing stopping me from approving this.
ruilopesm
commented
Aug 18, 2023
ruilopesm
force-pushed
the
rl/schemas-models-migrations
branch
from
167003c
to
36fc6ee
Compare
ruilopesm
changed the title
danielsp45
previously approved these changes
Aug 22, 2023
MarioRodrigues10
dismissed
danielsp45’s stale review
The rebase should be completed first, followed by solving any issues that may arise afterwards.
ruilopesm
force-pushed
the
rl/schemas-models-migrations
branch
from
aaca35f
to
8c3d0f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.