Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add credo configuration #326

Merged
merged 4 commits into from
Aug 20, 2023
Merged

chore: add credo configuration #326

merged 4 commits into from
Aug 20, 2023

Conversation

ruilopesm
Copy link
Member

No description provided.

@reviewpad
Copy link

reviewpad bot commented Aug 19, 2023

AI-Generated Summary: This pull request introduces a Credo configuration file for the Elixir project which set-ups various styles, design, readability and refactoring checks. It also modifies the lint command in mix.exs file to make use of this newly introduced configuration file. This commit contain modifications in different seed files to better align with the established code style and improve overall code readability. These changes include reordering of the alias declarations, refining the function names by removing unnecessary parenthesis, and adhering to the single responsibility principle by separating multiple aliases to individual lines.

@ruilopesm ruilopesm added enhancement New feature or improvements misc Miscellaneous labels Aug 19, 2023
@ruilopesm ruilopesm enabled auto-merge (squash) August 19, 2023 17:23
danielsp45
danielsp45 previously approved these changes Aug 20, 2023
Copy link
Member

@danielsp45 danielsp45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruilopesm ruilopesm merged commit 481cfda into develop Aug 20, 2023
3 checks passed
@ruilopesm ruilopesm deleted the rl/credo-config branch August 20, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvements misc Miscellaneous
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants