Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove breadcrumbs navigation #425

Merged
merged 1 commit into from
Sep 23, 2023
Merged

Conversation

joaodiaslobo
Copy link
Member

Remove the breadcrumb entries from all pages

@reviewpad
Copy link

reviewpad bot commented Sep 21, 2023

AI-Generated Summary: This pull request contains changes across multiple files, primarily focusing on refactoring breadcrumb navigation within the handle_params functions of various live view modules. The common pattern amongst these changes is the removal of hardcoded lists, called entries, containing breadcrumb link details, and their subsequent assignment to breadcrumb_entries.

Files affected are within the AtomicWeb module, including but not limited to: announcement_live/show.ex, board_live/new.ex, home_live/index.ex, organization_live/index.ex, organization_live/show.ex, announcement_live/edit.ex, activity_live/edit.ex, membership_live/index.ex, department_live/show.ex, organization_live/edit.ex, profile_live/show.ex, partner_live/show.ex, speaker_live/index.ex, scanner_live/index.ex, activity_live/index.ex, board_live/index.ex, speaker_live/show.ex, profile_live/edit.ex, department_live/index.ex, announcement_live/index.ex, partner_live/index.ex, membership_live/edit.ex and activity_live/show.ex.

This refactor not only removes the creation of these lists but also their assignment to socket. This set of changes could suggest a change in how breadcrumb navigation is handled within the application, potentially with a move towards a more dynamic creation or complete removal.

While this removal of associated breadcrumb coding simplifies the individual handle_params functions, developers should ensure these changes do not adversely affect the user interface if it was reliant on the breadcrumb_entries assignment to the socket. Apart from this specific pattern of removal, the rest of the code within the handle_params functions largely remains unchanged.

@joaodiaslobo joaodiaslobo merged commit 030fe06 into develop Sep 23, 2023
3 checks passed
@joaodiaslobo joaodiaslobo deleted the jl/remove-breadcrumbs branch September 23, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants