-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: partners pages #442
feat: partners pages #442
Conversation
The PR is done, although partner show page is looking a bit weird, I accept suggestions to improve it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like you didn't use the component used for page layouts. Notice the difference between one of the pages that uses it and yours:
This has to be done to make sure everything follows the same design principles such as margins, paddings, typography sizes, etc..
To use it you need to write something like this:
<.page title="Partners">
<:actions>
<%= if not @empty? and @has_permissions? do %>
<.primary_button url={Routes.partner_new_path(@socket, :new, @current_organization)}>
<%= gettext("New") %>
</.primary_button>
<% end %>
</:actions>
<!-- PARTNER INDEX CONTENT HERE -->
<./page>
Thanks for the heads up @joaodiaslobo . |
@joaodiaslobo i've already changed what you suggested, i'll wait now for your suggestion for the socials |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These brand icons should be monochromatic (not colored).
Font Awesome has them available here, and you can download them as SVGs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lib/atomic/partnerships.ex
Outdated
[%Partner{}, ...] | ||
|
||
""" | ||
def list_partners_by_organization_id(id) do | ||
Repo.all(from p in Partner, where: p.organization_id == ^id) | ||
def list_partners_by_organization_id(opts) when is_list(opts) do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is no longer a function that "lists partners by organization id", since now it receives a map of options, maybe change it to list_partners/1
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just needs some small adjustments and should be ready to be merged, thanks!
15a3332
to
c267f44
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! 🚀
No description provided.