feat: partners pages #442
feat: partners pages #442
Conversation
MarioRodrigues10
requested review from
ruilopesm,
joaodiaslobo,
danielsp45 and
ruioliveira02
|
The PR is done, although partner show page is looking a bit weird, I accept suggestions to improve it. |
There was a problem hiding this comment.
It seems like you didn't use the component used for page layouts. Notice the difference between one of the pages that uses it and yours:
This has to be done to make sure everything follows the same design principles such as margins, paddings, typography sizes, etc..
To use it you need to write something like this:
<.page title="Partners">
<:actions>
<%= if not @empty? and @has_permissions? do %>
<.primary_button url={Routes.partner_new_path(@socket, :new, @current_organization)}>
<%= gettext("New") %>
</.primary_button>
<% end %>
</:actions>
<!-- PARTNER INDEX CONTENT HERE -->
<./page>
|
Thanks for the heads up @joaodiaslobo . |
|
@joaodiaslobo i've already changed what you suggested, i'll wait now for your suggestion for the socials |
There was a problem hiding this comment.
These brand icons should be monochromatic (not colored).
Font Awesome has them available here, and you can download them as SVGs.
lib/atomic/partnerships.ex
Outdated
| [%Partner{}, ...] | ||
|
|
||
| """ | ||
| def list_partners_by_organization_id(id) do | ||
| Repo.all(from p in Partner, where: p.organization_id == ^id) | ||
| def list_partners_by_organization_id(opts) when is_list(opts) do |
There was a problem hiding this comment.
This is no longer a function that "lists partners by organization id", since now it receives a map of options, maybe change it to list_partners/1?
MarioRodrigues10
force-pushed
the
mr/update-partners-page
branch
from
15a3332
to
c267f44
Compare
No description provided.