Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: department pages #470

Merged
merged 47 commits into from
Apr 18, 2024
Merged

Conversation

joaodiaslobo
Copy link
Member

@joaodiaslobo joaodiaslobo commented Feb 24, 2024

This is kind of a big one, feel free to take your time to review this PR. The ultimate goal is for this to set the platforms' department features at a solid 80% 🚀

  • Department index with department cards (any)
  • Department show with department name, description, banner, collaborators snippet, recent activity (for now has an empty state because association logic is missing) (any)
  • Department show action buttons (ask to collaborate (any), view kanban board (collaborators & admin, will be done in another PR), view collaborators table (admin), edit department details (admin)
  • Change department name, description and banner (admin)
  • Chose whether a department is accepting new collaborators (admin)
  • View collaborators, and requests to join (admin)
  • Approve or deny collaborator requests
  • View collaborators (user)
  • Request to join department (any)
  • Ability to archive departments (admin)
  • Email to all admins of an organization collaborators of a department on new collaborator request (admin)
  • Email to collaborator when their request is accepted (any)

Also adds a cool gradient component that can be used for placeholder banners and such.
Also fixes some missing associations related to the user entity.

image

@joaodiaslobo joaodiaslobo self-assigned this Feb 24, 2024
lib/atomic/uploaders/banner.ex Outdated Show resolved Hide resolved
lib/atomic_web/live/collaborator_live/form_component.ex Outdated Show resolved Hide resolved
lib/atomic_web/live/collaborator_live/form_component.ex Outdated Show resolved Hide resolved
lib/atomic_web/live/collaborator_live/form_component.ex Outdated Show resolved Hide resolved
lib/atomic_web/live/department_live/edit.ex Show resolved Hide resolved
lib/atomic_web/live/department_live/edit.html.heex Outdated Show resolved Hide resolved
lib/atomic_web/live/department_live/form_component.ex Outdated Show resolved Hide resolved
Copy link
Member

@MarioRodrigues10 MarioRodrigues10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An email should be send when an user applies to be a collaborator and when it's accepted.

Copy link
Member

@MarioRodrigues10 MarioRodrigues10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joaodiaslobo joaodiaslobo merged commit 8562dce into develop Apr 18, 2024
2 checks passed
@joaodiaslobo joaodiaslobo deleted the jl/improve-departments-pages branch April 18, 2024 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants