Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: dropdown component #483

Merged
merged 16 commits into from
Mar 20, 2024
Merged

feat: dropdown component #483

merged 16 commits into from
Mar 20, 2024

Conversation

MarioRodrigues10
Copy link
Member

The component is implemented at calendar page.

@MarioRodrigues10 MarioRodrigues10 self-assigned this Mar 9, 2024
joaodiaslobo
joaodiaslobo requested changes Mar 11, 2024
View reviewed changes
lib/atomic_web/components/dropdown.ex Show resolved Hide resolved
lib/atomic_web/components/dropdown.ex Outdated Show resolved Hide resolved
assets/js/app.js Outdated Show resolved Hide resolved
joaodiaslobo
joaodiaslobo requested changes Mar 18, 2024
View reviewed changes
assets/js/app.js Outdated Show resolved Hide resolved
lib/atomic_web/components/calendar/calendar.ex Outdated Show resolved Hide resolved
lib/atomic_web/templates/layout/_live_navbar.html.heex Outdated Show resolved Hide resolved
lib/atomic_web/templates/layout/_live_navbar.html.heex Outdated Show resolved Hide resolved
lib/atomic_web/live/membership_live/index.html.heex Outdated Show resolved Hide resolved
storybook/components/dropdown.story.exs Outdated Show resolved Hide resolved
storybook/components/dropdown.story.exs Outdated Show resolved Hide resolved
lib/atomic_web/components/dropdown.ex Outdated Show resolved Hide resolved
ruilopesm
ruilopesm reviewed Mar 18, 2024
View reviewed changes
assets/js/app.js Outdated Show resolved Hide resolved
@ruilopesm ruilopesm linked an issue Mar 19, 2024 that may be closed by this pull request
Create dropdown component #488
Closed
1 task
ruilopesm
ruilopesm reviewed Mar 20, 2024
View reviewed changes
Copy link
Member

@ruilopesm ruilopesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

User dropdown is a bit weird for me 😅
Apart from that, great work! 🙌🏼

image

joaodiaslobo
joaodiaslobo approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@joaodiaslobo joaodiaslobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 🚀

@MarioRodrigues10 MarioRodrigues10 merged commit 1968d58 into develop Mar 20, 2024
2 checks passed
@MarioRodrigues10 MarioRodrigues10 deleted the mr/dropdown branch March 20, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaodiaslobo joaodiaslobo joaodiaslobo approved these changes

@danielsp45 danielsp45 Awaiting requested review from danielsp45

@ruilopesm ruilopesm Awaiting requested review from ruilopesm

Assignees

@MarioRodrigues10 MarioRodrigues10

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create dropdown component
3 participants
@MarioRodrigues10 @joaodiaslobo @ruilopesm