Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhance dropdown component with link navigation options and transitions #523

Merged
merged 4 commits into from
Aug 22, 2024

Conversation

nunom27
Copy link
Contributor

@nunom27 nunom27 commented Aug 21, 2024

No description provided.

@nunom27 nunom27 self-assigned this Aug 21, 2024
@nunom27 nunom27 marked this pull request as ready for review August 22, 2024 14:57
Copy link
Member

@joaodiaslobo joaodiaslobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Very nice changes! 🎉
If you can, please add module documentation to lib/atomic_web/components/dropdown.ex like it's done on the map component, thanks!

ruilopesm
ruilopesm previously approved these changes Aug 22, 2024
Copy link
Member

@joaodiaslobo joaodiaslobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@nunom27 nunom27 merged commit a78995c into develop Aug 22, 2024
2 checks passed
@nunom27 nunom27 deleted the nm/enhance-dropdown branch August 22, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants