Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small changes for version 5 #51

Merged
merged 9 commits into from
Jun 17, 2022
Merged

small changes for version 5 #51

merged 9 commits into from
Jun 17, 2022

Conversation

kwantam
Copy link
Collaborator

@kwantam kwantam commented Jun 16, 2022

In an effort to get this document back up and running, I'm going to update to v5 soon.

This PR brings in the changes from issue #48, closes PR #50, and adds @chris-wood as an author of the document.

@chris-wood, if you have time for a quick look at these edits, I'd appreciate it!

We have lots to fix between now and v6; at least this gets us started :)

@kwantam kwantam requested a review from chris-wood June 16, 2022 23:11
kwantam added 2 commits June 16, 2022 23:10
this commit reverts the changes made in cfrg#40. These can be brought back
in v6. I am removing for the v5 draft because I do not want to release
such a dramatic change without further vetting.
@kwantam
Copy link
Collaborator Author

kwantam commented Jun 17, 2022

I have just added a commit that reverts the strawman patch for #38 that was incorporated via #40. This needs further vetting before being pushed to datatracker. After releasing v5, I will bring it back for v6 and we can continue improving it.

@kwantam
Copy link
Collaborator Author

kwantam commented Jun 17, 2022

Checked in the -05 submitted files, reverted the commit that undid the #38 fix, bumped version to -06. Merging this PR now and we can continue working from here.

@kwantam kwantam merged commit 2bd80b1 into cfrg:master Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants