Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation Enablement #3

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Translation Enablement #3

wants to merge 4 commits into from

Conversation

srl295
Copy link

@srl295 srl295 commented May 25, 2016

  • uses (requires) the Globalization Pipeline bound service
  • use npm run gen-i18n to pickup any changes to index.html
  • use localized number formatting on the client side
  • escape HTML from Hey <b>you!</b> to Hey {b}you!{/b} for translation

Fixes: #1

( Note: this PR currently includes my other PR #2 ), which has generic non-international improvements.

* use cfenv for cloudfoundry parameter load - simplify VCAP stuff
* Support `local-vcap.json` file for local running
* remove local credentials
* cleanup package.json (license) and .gitignore
* When running locally, use ./mqtt.log instead of ../logs/mqtt.log
* This quells an error and provides local testing
* Also update .gitignore
@srl295 srl295 changed the title Translation Enablement - Phase 1A Translation Enablement May 25, 2016
* uses (requires) the Globalization Pipeline bound service
* use `npm run gen-i18n` to pickup any changes to index.html
* use localized number formatting on the client side
* escape HTML from `Hey <b>you!</b>` to `Hey {b}you!{/b}` for translation

Fixes: cfsworkload#1
@srl295
Copy link
Author

srl295 commented May 25, 2016

  • detection works for some sublocales
  • specifically, zh-cn and zh-tw handled
    • could leverage CLDR metadata to do additional lookups

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant