Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xfield_tracer bug #20

Open
yDF8EPJN8 opened this issue Aug 6, 2024 · 3 comments
Open

xfield_tracer bug #20

yDF8EPJN8 opened this issue Aug 6, 2024 · 3 comments

Comments

@yDF8EPJN8
Copy link

bug in the xfield_tracer project in the vert_field_graph.h file at line 1353

if (IndexNodes.count(Nodes[i].Neigh[j].Node>0))continue;

It should be
if (IndexNodes.count(Nodes[i].Neigh[j].Node)>0)continue;
mheistermann added a commit to cgg-bern/xfield_tracer_fork that referenced this issue Aug 7, 2024
@mheistermann
Bugfix:
2913b67 
Reported here by 'yDF8EPJN8':
cgg-bern/quadwild-bimdf#20
@mheistermann
Copy link
Member

Thanks for the report!
I applied the change in cgg-bern/xfield_tracer_fork@2913b67

Do you know what impact this bug had?

@mheistermann mheistermann mentioned this issue Aug 7, 2024
Open
@yDF8EPJN8
Copy link
Author

I don't know, it's better to ask the author of the code.

@thuliu-yt16
Copy link

I guess sometimes patches will be missing in the final result. I encountered the problem and solved it by applying this modification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mheistermann @thuliu-yt16 @yDF8EPJN8