Integrate chai-subset into chai core
#1621
Conversation
Use chai.use for adding method
Use Chai to perform diffs
v1.1.0 assert style of test, rm jshint, add jscs eslint, better coverage, fixes chaijs#13
v1.1.0 assert style of test, rm jshint, add jscs eslint, better coverage, fixes chaijs#13
Comparison of Dates
Comparison of Dates
If two objects are the same, then inherently they're subsets of each other. This also fixes a bug I've run into with testing recursive data structures.
…ijs#66) * Adding compare function to be used in expected object template * Adding compare function example to README.md
…ijs#66) * Adding compare function to be used in expected object template * Adding compare function example to README.md
|
it looks good to me but i have a couple of thoughts: 1 - i know you put effort into keeping the git history but i'd actually squash this anyway if we merge it as i don't think the subset history makes sense in our tree. it may be better to just note somewhere this was originally built by andrii 2 - something's bugging me about the overlap here of i wonder if we can at least extract the traversal logic so they both share it, or we make |
We'll likely have similar logic in |
|
I'll start looking at squaring this up according to the comments. |
|
I'm cleaning up some old PRs and am gonna close this. I'll re-open a different one if I end up working on this. |
I tried to make sure to preserve the
chai-subsethistory when doing this.Fixes #1616